Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers.

Jeff Garzik
2008-07-15T03:15:56Z

Linus Torvalds wrote:
>
> On Mon, 14 Jul 2008, Jeff Garzik wrote:
>> My complaints are about --not breaking stuff--, not request_firmware().
>
> Guys, request_firmware() has been around for about five years now.
>
> If this discussion had happened in 2003, I'd agree.
>
> As it is, I think it's time to just face it - many people do want to have
> a unified interface (and yes, I obviously count myself in that group), and
> you can't just continue do nothing and ignore that.
>
> Your argument seems to be that you don't want to break anything, but
> you've also clearly not wanted to _fix_ anything for the last five years.
>
> At some point, somebody has to just do it. And five years is _way_ long
> enough.

In threads of years past, you've agreed with the plainly obvious --
built-in firmware is obviously more reliable, and is more likely to
produce a working driver.

It doesn't break anything to keep this feature.

Keeping this feature doesn't prevent any other fixes.

Keeping this feature closes the window for potential regressions.

And keeping this feature means Linux users can make a _choice_, rather
than forcing /lib/firmware on them.

Do you really think embedded system and micro distro authors are in 100%
agreement that /lib/firmware is best for their situation? Really?

Jeff