From: Masami Hiramatsu <mhiramat@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
"Frank Ch. Eigler" <fche@redhat.com>,
Hideo AOKI <haoki@redhat.com>,
Takashi Nishiie <t-nishiie@np.css.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Paul E McKenney <paulmck@linux.vnet.ibm.com>
Subject: Re: [patch 01/15] Kernel Tracepoints
Date: Tue, 15 Jul 2008 14:52:54 -0400 [thread overview]
Message-ID: <487CF206.4010905@redhat.com> (raw)
In-Reply-To: <1216134829.12595.207.camel@twins>
Hi,
Peter Zijlstra wrote:
> On Tue, 2008-07-15 at 10:46 -0400, Mathieu Desnoyers wrote:
>
>> Talking about headers, I have noticed that placing headers with the code
>> may not be as clean as I would hope. For instance, the kernel/irq-trace.h
>> header, when included from kernel/irq/handle.c, has to be included with:
>>
>> #include "../irq-trace.h"
>>
>> Which is not _that_ bad, but we we want to instrument the irq handler
>> found in arch/x86/kernel/cpu/mcheck/mce_intel_64.c, including
>> #include "../../../../../kernel/irq-trace.h" makes me go "yeeeek!"
>>
>> How about creating include/trace/irq.h and friends ?
>
> Might as well.. anybody else got opinions?
I just wonder why DEFINE_TRACE are used in separated headers
instead of include/linux/irq.h directly.
anyway, #include <trace/XXX.h> is good to me.
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2008-07-15 18:55 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 14:59 [patch 00/15] Tracepoints v3 for linux-next Mathieu Desnoyers
2008-07-09 14:59 ` [patch 01/15] Kernel Tracepoints Mathieu Desnoyers
2008-07-15 7:50 ` Peter Zijlstra
2008-07-15 13:25 ` Mathieu Desnoyers
2008-07-15 13:59 ` Peter Zijlstra
2008-07-15 14:27 ` Mathieu Desnoyers
2008-07-15 14:42 ` Peter Zijlstra
2008-07-15 15:22 ` Mathieu Desnoyers
2008-07-15 15:31 ` Peter Zijlstra
2008-07-15 15:50 ` Mathieu Desnoyers
2008-08-01 21:10 ` Paul E. McKenney
2008-07-15 16:08 ` Mathieu Desnoyers
2008-07-15 16:25 ` Peter Zijlstra
2008-07-15 16:51 ` Mathieu Desnoyers
2008-08-01 21:10 ` Paul E. McKenney
2008-08-02 0:03 ` Peter Zijlstra
2008-08-02 0:17 ` Paul E. McKenney
2008-08-01 21:10 ` Paul E. McKenney
2008-07-15 16:26 ` Mathieu Desnoyers
2008-08-01 21:10 ` Paul E. McKenney
2008-07-15 17:50 ` Mathieu Desnoyers
2008-07-15 14:03 ` Peter Zijlstra
2008-07-15 14:46 ` Mathieu Desnoyers
2008-07-15 15:13 ` Peter Zijlstra
2008-07-15 18:22 ` Mathieu Desnoyers
2008-07-15 18:33 ` Steven Rostedt
2008-07-15 18:52 ` Masami Hiramatsu [this message]
2008-07-15 19:08 ` Mathieu Desnoyers
2008-07-15 19:02 ` Mathieu Desnoyers
2008-07-15 19:52 ` Peter Zijlstra
2008-07-09 14:59 ` [patch 02/15] Tracepoints Documentation Mathieu Desnoyers
2008-07-09 14:59 ` [patch 03/15] Tracepoints Samples Mathieu Desnoyers
2008-07-09 14:59 ` [patch 04/15] LTTng instrumentation - irq Mathieu Desnoyers
2008-07-09 16:39 ` Masami Hiramatsu
2008-07-09 17:05 ` [patch 04/15] LTTng instrumentation - irq (update) Mathieu Desnoyers
2008-07-09 14:59 ` [patch 05/15] LTTng instrumentation - scheduler Mathieu Desnoyers
2008-07-09 15:34 ` [patch 05/15] LTTng instrumentation - scheduler (repost) Mathieu Desnoyers
2008-07-09 15:39 ` Ingo Molnar
2008-07-09 16:00 ` Mathieu Desnoyers
2008-07-09 16:21 ` [patch 05/15] LTTng instrumentation - scheduler (merge ftrace markers) Mathieu Desnoyers
2008-07-09 19:09 ` [PATCH] ftrace port to tracepoints (linux-next) Mathieu Desnoyers
2008-07-10 3:14 ` Takashi Nishiie
2008-07-10 3:57 ` [PATCH] ftrace port to tracepoints (linux-next) (nitpick update) Mathieu Desnoyers
[not found] ` <20080711143709.GB11500@Krystal>
[not found] ` <Pine.LNX.4.58.0807141112540.30484@gandalf.stny.rr.com>
[not found] ` <20080714153334.GA651@Krystal>
[not found] ` <Pine.LNX.4.58.0807141153250.29493@gandalf.stny.rr.com>
2008-07-14 16:25 ` [PATCH] ftrace memory barriers Mathieu Desnoyers
2008-07-14 16:35 ` Steven Rostedt
2008-07-09 14:59 ` [patch 06/15] LTTng instrumentation - timer Mathieu Desnoyers
2008-07-09 14:59 ` [patch 07/15] LTTng instrumentation - kernel Mathieu Desnoyers
2008-07-09 14:59 ` [patch 08/15] LTTng instrumentation - filemap Mathieu Desnoyers
2008-07-09 14:59 ` [patch 09/15] LTTng instrumentation - swap Mathieu Desnoyers
2008-07-09 14:59 ` [patch 10/15] LTTng instrumentation - memory page faults Mathieu Desnoyers
2008-07-09 14:59 ` [patch 11/15] LTTng instrumentation - page Mathieu Desnoyers
2008-07-09 14:59 ` [patch 12/15] LTTng instrumentation - hugetlb Mathieu Desnoyers
2008-07-11 14:30 ` [patch 12/15] LTTng instrumentation - hugetlb (update) Mathieu Desnoyers
2008-07-09 14:59 ` [patch 13/15] LTTng instrumentation - net Mathieu Desnoyers
2008-07-09 14:59 ` [patch 14/15] LTTng instrumentation - ipv4 Mathieu Desnoyers
2008-07-09 14:59 ` Mathieu Desnoyers
2008-07-09 17:01 ` [patch 00/15] Tracepoints v3 for linux-next Masami Hiramatsu
2008-07-09 17:11 ` [patch 15/15] LTTng instrumentation - ipv6 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487CF206.4010905@redhat.com \
--to=mhiramat@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=fche@redhat.com \
--cc=haoki@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=t-nishiie@np.css.fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox