From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] mm: fix ptep_modify_* for no-MMU systems
Date: Tue, 15 Jul 2008 13:39:07 -0700 [thread overview]
Message-ID: <487D0AEB.6080304@goop.org> (raw)
In-Reply-To: <8bd0f97a0807150724x8f7095dl9b5d2e203053223f@mail.gmail.com>
Fixes build problem:
the functions added to asm-generic/pgtable.h are only used by
mm/mprotect.c (a MMU-only file), but they were not added inside of the
CONFIG_MMU ifdef block. since the functions rely on things inside of
CONFIG_MMU (the lines just above in pgtable.h), we get build failure
on all no-mmu setups:
CC init/main.o
In file included from include/asm/pgtable.h:94,
from include/linux/mm.h:39,
from include/asm/dma.h:39,
from include/linux/bootmem.h:8,
from init/main.c:27:
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
include/asm-generic/pgtable.h:210: error: implicit declaration of
function 'ptep_get_and_clear'
include/asm-generic/pgtable.h:210: error: incompatible types in return
make[1]: *** [init/main.o] Error 1
make: *** [init/main.o] Error 2
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Mike Frysinger <vapier.adi@gmail.com>
---
include/asm-generic/pgtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
===================================================================
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -195,7 +195,6 @@
}
return 0;
}
-#endif /* CONFIG_MMU */
static inline pte_t __ptep_modify_prot_start(struct mm_struct *mm,
unsigned long addr,
@@ -253,6 +252,7 @@
__ptep_modify_prot_commit(mm, addr, ptep, pte);
}
#endif /* __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION */
+#endif /* CONFIG_MMU */
/*
* A facility to provide lazy MMU batching. This allows PTE updates and
next prev parent reply other threads:[~2008-07-15 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 13:38 linux-next: 1ea0704e (ptep_modify_prot transaction abstraction) breaks no-mmu Mike Frysinger
2008-07-03 15:53 ` Jeremy Fitzhardinge
2008-07-15 14:00 ` Adrian Bunk
2008-07-15 14:24 ` Mike Frysinger
2008-07-15 20:39 ` Jeremy Fitzhardinge [this message]
2008-07-16 12:52 ` [PATCH] mm: fix ptep_modify_* for no-MMU systems Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487D0AEB.6080304@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox