From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] mm: fix build on non-mmu machines
Date: Tue, 15 Jul 2008 13:49:07 -0700 [thread overview]
Message-ID: <487D0D43.2000003@goop.org> (raw)
In-Reply-To: <20080715202846.GA8867@www.tglx.de>
Sebastian Siewior wrote:
> Commit 1ea0704e0d aka
> [mm: add a ptep_modify_prot transaction abstraction]
>
> caused:
>
> | CC init/main.o
> |In file included from include2/asm/pgtable.h:68,
> | from /home/bigeasy/git/linux-2.6-m68k/include/linux/mm.h:39,
> | from include2/asm/uaccess.h:8,
> | from /home/bigeasy/git/linux-2.6-m68k/include/linux/poll.h:13,
> | from /home/bigeasy/git/linux-2.6-m68k/include/linux/rtc.h:113,
> | from /home/bigeasy/git/linux-2.6-m68k/include/linux/efi.h:19,
> | from /home/bigeasy/git/linux-2.6-m68k/init/main.c:43:
> |/linux-2.6/include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
> |/linux-2.6/include/asm-generic/pgtable.h:209: error: implicit declaration of function 'ptep_get_and_clear'
> |/linux-2.6/include/asm-generic/pgtable.h:209: error: incompatible types in return
> |/linux-2.6/include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
> |/linux-2.6/include/asm-generic/pgtable.h:220: error: implicit declaration of function 'set_pte_at'
> |make[2]: *** [init/main.o] Error 1
> |make[1]: *** [init] Error 2
> |make: *** [sub-make] Error 2
>
> on my m68knommu box.
> Now I'm, not sure If this is the right solution, but with this
> patch applied I am able to boot the kernel I've build.
>
I just posted an identical patch, so I'll take that as confirmation that
it works ;)
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
J
prev parent reply other threads:[~2008-07-15 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 20:28 [PATCH] mm: fix build on non-mmu machines Sebastian Siewior
2008-07-15 20:49 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487D0D43.2000003@goop.org \
--to=jeremy@goop.org \
--cc=bigeasy@linutronix.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox