From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
virtualization@lists.linux-foundation.org,
Zachary Amsden <zach@vmware.com>,
Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [PATCH] stopmachine: add stopmachine_timeout v2
Date: Thu, 17 Jul 2008 12:40:14 +0900 [thread overview]
Message-ID: <487EBF1E.5030109@jp.fujitsu.com> (raw)
In-Reply-To: <487DC943.5060202@goop.org>
Jeremy Fitzhardinge wrote:
> Hidetoshi Seto wrote:
>> +#ifdef CONFIG_STOP_MACHINE
>> +extern unsigned long stopmachine_timeout;
>> +#endif
>
> No externs in C files. Put it in an appropriate header.
sysctl.c already has many externs... but I can fix at least
the above.
> I'll do a proper review soon.
Is it better to postpone v4 until your comment comes?
Thanks,
H.Seto
next prev parent reply other threads:[~2008-07-17 3:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 7:52 [PATCH] stopmachine: add stopmachine_timeout Hidetoshi Seto
2008-07-14 8:19 ` Hidetoshi Seto
2008-07-14 10:43 ` Rusty Russell
2008-07-15 1:11 ` Hidetoshi Seto
2008-07-15 7:50 ` Rusty Russell
2008-07-16 4:05 ` Hidetoshi Seto
2008-07-20 9:45 ` Rusty Russell
2008-07-22 3:28 ` [PATCH] stopmachine: allow force progress on timeout Hidetoshi Seto
2008-07-14 11:51 ` [PATCH] stopmachine: add stopmachine_timeout Christian Borntraeger
2008-07-14 12:34 ` Rusty Russell
2008-07-14 18:56 ` Jeremy Fitzhardinge
2008-07-14 21:20 ` Heiko Carstens
2008-07-15 1:14 ` Rusty Russell
2008-07-15 2:24 ` Hidetoshi Seto
2008-07-15 2:37 ` Max Krasnyansky
2008-07-15 2:24 ` Max Krasnyansky
2008-07-15 6:09 ` Heiko Carstens
2008-07-15 8:09 ` Rusty Russell
2008-07-15 8:39 ` Heiko Carstens
2008-07-15 8:51 ` Max Krasnyansky
2008-07-16 9:15 ` Christian Borntraeger
2008-07-16 4:27 ` [PATCH] stopmachine: add stopmachine_timeout v2 Hidetoshi Seto
2008-07-16 6:23 ` Max Krasnyansky
2008-07-16 6:35 ` Hidetoshi Seto
2008-07-16 6:51 ` [PATCH] stopmachine: add stopmachine_timeout v3 Hidetoshi Seto
2008-07-16 7:33 ` Peter Zijlstra
2008-07-16 8:12 ` Hidetoshi Seto
2008-07-16 10:11 ` [PATCH] stopmachine: add stopmachine_timeout v2 Jeremy Fitzhardinge
2008-07-17 3:40 ` Hidetoshi Seto [this message]
2008-07-17 5:37 ` Jeremy Fitzhardinge
2008-07-18 4:18 ` Rusty Russell
2008-07-17 6:12 ` [PATCH] stopmachine: add stopmachine_timeout v4 Hidetoshi Seto
2008-07-17 7:09 ` Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487EBF1E.5030109@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox