From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] at91_mci: Do a reset after each request
Date: Thu, 17 Jul 2008 11:34:50 +0200 [thread overview]
Message-ID: <487F123A.4050502@atmel.com> (raw)
From: Ville Syrjala <syrjala@sci.fi>
Reset the controller after each transfer since we're violating the
spec sometimes. This is very cheap, so we don't try to be clever.
Signed-off-by: Ville Syrjala <syrjala@sci.fi>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Comment stolen from atmel_mci log.
We noticed that AT91SAM9260 board + Marvell 8686 SDIO WLAN adater
are not happy without applying the MCI reset trick.
drivers/mmc/host/at91_mci.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
index f3d725e..4e3edf3 100644
--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -670,11 +670,10 @@ static void at91_mci_process_next(struct
at91mci_host *host)
at91_mci_send_command(host, host->request->stop);
} else {
del_timer(&host->timer);
- /* the at91rm9200 mci controller hangs after some transfers,
+ /* the mci controller hangs after some transfers,
* and the workaround is to reset it after each transfer.
*/
- if (cpu_is_at91rm9200())
- at91_reset_host(host);
+ at91_reset_host(host);
mmc_request_done(host->mmc, host->request);
}
}
--
1.5.3.7
reply other threads:[~2008-07-17 9:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487F123A.4050502@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox