public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Paul Jackson <pj@sgi.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, menage@google.com,
	peterz@infradead.org, akpm@linux-foundation.org,
	laijs@cn.fujitsu.com
Subject: Re: [RFC] [PATCH] cpuset: fix wrong calculation of relax domain level
Date: Fri, 18 Jul 2008 09:26:28 +0900	[thread overview]
Message-ID: <487FE334.6070807@jp.fujitsu.com> (raw)
In-Reply-To: <20080717152833.1e14a1c4.pj@sgi.com>

Paul Jackson wrote:
> Question:
> 
>     In the case that the top_cpuset's sched_load_balance is -not- set,
>     is there code already present that sets the sched_relax_domain_level
>     in overlapping cpusets to the largest value in any of the overlapping
>     cpusets?
> 
>     If so, where is that code?
> 

My humble answer:

static void rebuild_sched_domains(void)
{
 :
	while (__kfifo_get(q, (void *)&cp, sizeof(cp))) {
	//  pick up cpusets with sched_load_balance = 1
	}
 :
restart:
	/* Find the best partition (set of sched domains) */
	for (i = 0; i < csn; i++) {
	// check overlap and set proper partition number
	}
 :
	for (nslot = 0, i = 0; i < csn; i++) {
 :
				if (apn == b->pn) {
					// make map and attr from all cpusets
					// having same partition number
					cpus_or(*dp, *dp, b->cpus_allowed);
					b->pn = -1;
					if (dattr)
						update_domain_attr(dattr
								   + nslot, b);
                                }
 :
        }
 :
rebuild:
 :
done:
 :
}

So the codes you searching is near by 'update_domain_attr' above, I guess.

Thanks,
H.Seto

  reply	other threads:[~2008-07-18  0:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17  8:07 [RFC] [PATCH] cpuset: fix wrong calculation of relax domain level Li Zefan
2008-07-17  8:57 ` Hidetoshi Seto
2008-07-17 10:13   ` Li Zefan
2008-07-17 20:09     ` Paul Jackson
2008-07-17 20:28 ` Paul Jackson
2008-07-18  0:26   ` Hidetoshi Seto [this message]
2008-07-18  0:35     ` Paul Jackson
2008-07-18  2:36   ` Li Zefan
2008-07-18  2:43     ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487FE334.6070807@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=peterz@infradead.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox