Re: [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction

Mark Brown
2023-01-12T18:41:50Z

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Thu, Jan 12, 2023 at 11:38:38AM -0600, Pierre-Louis Bossart wrote:

> > +static int regmap_sdw_gather_write(void *context,
> > + const void *reg_buf, size_t reg_size,
> > + const void *val_buf, size_t val_size)
> > {
> > struct device *dev = context;
> > struct sdw_slave *slave = dev_to_sdw_dev(dev);
> > - int read;
> > + u32 addr = le32_to_cpu(*(const __le32 *)reg_buf);

> what's the difference between regmap_sdw_write() and
> regmap_sdw_gather_write()? Seems to me that it's the same functionality
> of writing at consecutive addresses. It's not a true 'gather' in the
> sense that only the first address is used?

The regmap gather_write() operation allows the bus to take two buffers,
one for the register and one for the value, rather than requiring the
core combine everything into a single buffer (mainly useful for large
transfers like firmware downloads).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]