From: Tejun Heo <tj@kernel.org>
To: chunbo.luo@windriver.com
Cc: linux-kernel@vger.kernel.org, jeff@garzik.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled
Date: Fri, 18 Jul 2008 22:33:20 +0900 [thread overview]
Message-ID: <48809BA0.8060500@kernel.org> (raw)
In-Reply-To: <1214533246.6284.10.camel@pek-cluo>
Chunbo Luo wrote:
> Hi
>
> When ata_scsi_scan_host() scan device failed, it will start a work queue
> unconditionally. This may cause some noisy messages. This patch fix this
> problem.
ATA_PFLAG_SCSI_HOTPLUG doesn't mean that hotplug is enabled. It
indicates that EH needs to schedule a kick at SCSI's ass and make it
scan for discovered devices && work running on ata_aux_wq testing it
doesn't mean anything. There's no synchronization.
> Previously, queue_delayed_work() was started unconditionally, but if
> ATA_PFLAG_SCSI_HOTPLUG is not set and we do this, the work queue may
> cause multiple messages like this:
>
> ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
And this message has nothing to do with SCSI. It's printed by libata
proper for several drivers which don't support ATAPI. Did the patch
really kill the warning messages? Can you please post full boot log
from 2.6.26 w/o the patch?
Andrew, please drop the patch from -mm. Thanks.
--
tejun
next prev parent reply other threads:[~2008-07-19 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 2:20 [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled Chunbo Luo
2008-07-18 13:33 ` Tejun Heo [this message]
2008-07-21 3:03 ` Chunbo Luo
2008-07-21 4:40 ` Tejun Heo
2008-07-21 6:16 ` Chunbo Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48809BA0.8060500@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chunbo.luo@windriver.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox