* [PATCH] slub: dump more data on slab corruption
@ 2008-07-18 14:29 Pekka J Enberg
2008-07-18 14:32 ` Christoph Lameter
2008-07-18 20:26 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Pekka J Enberg @ 2008-07-18 14:29 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, cl
From: Pekka Enberg <penberg@cs.helsinki.fi>
The limit to 128 bytes is too small when debugging slab corruption of the skb
cache, for example. Increase the limit to PAGE_SIZE to make debugging
corruptions sligthly easier.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2008-07-18 17:26:01.000000000 +0300
+++ linux-2.6/mm/slub.c 2008-07-18 17:26:09.000000000 +0300
@@ -492,7 +492,7 @@
if (p > addr + 16)
print_section("Bytes b4", p - 16, 16);
- print_section("Object", p, min(s->objsize, 128));
+ print_section("Object", p, min_t(unsigned long, s->objsize, PAGE_SIZE));
if (s->flags & SLAB_RED_ZONE)
print_section("Redzone", p + s->objsize,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: dump more data on slab corruption
2008-07-18 14:29 [PATCH] slub: dump more data on slab corruption Pekka J Enberg
@ 2008-07-18 14:32 ` Christoph Lameter
2008-07-18 20:26 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Lameter @ 2008-07-18 14:32 UTC (permalink / raw)
To: Pekka J Enberg; +Cc: linux-kernel, mingo
Acked-by: Christoph Lameter <cl@linux-foundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: dump more data on slab corruption
2008-07-18 14:29 [PATCH] slub: dump more data on slab corruption Pekka J Enberg
2008-07-18 14:32 ` Christoph Lameter
@ 2008-07-18 20:26 ` Ingo Molnar
2008-07-19 11:20 ` Pekka Enberg
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-07-18 20:26 UTC (permalink / raw)
To: Pekka J Enberg; +Cc: linux-kernel, cl
* Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> The limit to 128 bytes is too small when debugging slab corruption of the skb
> cache, for example. Increase the limit to PAGE_SIZE to make debugging
> corruptions sligthly easier.
>
> Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slub: dump more data on slab corruption
2008-07-18 20:26 ` Ingo Molnar
@ 2008-07-19 11:20 ` Pekka Enberg
0 siblings, 0 replies; 4+ messages in thread
From: Pekka Enberg @ 2008-07-19 11:20 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, cl
On Fri, 2008-07-18 at 22:26 +0200, Ingo Molnar wrote:
> * Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
>
> > From: Pekka Enberg <penberg@cs.helsinki.fi>
> >
> > The limit to 128 bytes is too small when debugging slab corruption of the skb
> > cache, for example. Increase the limit to PAGE_SIZE to make debugging
> > corruptions sligthly easier.
> >
> > Cc: Ingo Molnar <mingo@elte.hu>
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-19 11:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-18 14:29 [PATCH] slub: dump more data on slab corruption Pekka J Enberg
2008-07-18 14:32 ` Christoph Lameter
2008-07-18 20:26 ` Ingo Molnar
2008-07-19 11:20 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox