From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Current git fails to compile
Date: Fri, 18 Jul 2008 07:33:52 -0700 [thread overview]
Message-ID: <4880A9D0.3060300@goop.org> (raw)
In-Reply-To: <20080718134126.GA30416@linux.vnet.ibm.com>
Dhaval Giani wrote:
> This patch also pulls the pmd preallocation and mop-up functions out
> to be common, assuming that the compiler will generate no code for
> them when PREALLOCTED_PMDS is 0.
Well, there's nothing particularly special in that code. The only
slightly complex requirement on the compiler is that it notice that a
0-iteration for loop is a do-nothing, and that it eliminate the code.
And that's not really a requirement, it's just nice to have.
The fact that your compiler is warning about an unused variable in an
unused function suggests that it isn't doing this (I'm assuming your
config has CONFIG_X86_PAE=n). But there are no inline asms or other
things which traditionally cause compilers to fall over.
So, I'm not really sure what to do about this. Any chance of using a
newer compiler?
J
prev parent reply other threads:[~2008-07-18 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 7:53 Current git fails to compile Dhaval Giani
2008-07-18 9:14 ` Ingo Molnar
2008-07-18 13:41 ` Dhaval Giani
2008-07-18 14:33 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4880A9D0.3060300@goop.org \
--to=jeremy@goop.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox