public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, ralf@linux-mips.org,
	linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core
Date: Fri, 18 Jul 2008 12:50:08 -0500	[thread overview]
Message-ID: <4880D7D0.9040200@windriver.com> (raw)
In-Reply-To: <20080719.023116.122828931.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:
> 
> The kgdb_ealy_setup check should be at beginning of init_IRQ (before
> set_irq_noprobe loop)?


I would agree, and it looks like the following now in the patch.
I will revalidate with the HW to ensure there is no regression. :-)

Jason.

@@ -130,8 +135,18 @@ void __init init_IRQ(void)
 {
 	int i;
 
+#ifdef CONFIG_KGDB
+	if (kgdb_early_setup)
+		return;
+#endif
+
 	for (i = 0; i < NR_IRQS; i++)
 		set_irq_noprobe(i);
 
 	arch_init_irq();
+
+#ifdef CONFIG_KGDB
+	if (!kgdb_early_setup)
+		kgdb_early_setup = 1;
+#endif
 }

  reply	other threads:[~2008-07-18 17:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 17:08 [PATCH 0/3] kgdb 2.6.27 mips Jason Wessel
2008-07-18 17:08 ` [PATCH 1/3] kgdb, mips: Remove existing kgdb implementation Jason Wessel
2008-07-18 17:08   ` [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core Jason Wessel
2008-07-18 17:08     ` [PATCH 3/3] kgdb, mips: pad pt_regs on MIPS64 for function arguments in an exception Jason Wessel
2008-07-18 17:31     ` [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core Atsushi Nemoto
2008-07-18 17:50       ` Jason Wessel [this message]
2008-07-24 16:27     ` Atsushi Nemoto
2008-07-25  3:00       ` Jason Wessel
2008-07-25 14:52         ` Atsushi Nemoto
2008-07-28 14:05           ` Atsushi Nemoto
2008-07-28 18:50             ` Jason Wessel
2008-07-29  1:24               ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4880D7D0.9040200@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox