public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Beulich <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit	arch-s
Date: Fri, 18 Jul 2008 19:57:41 +0200	[thread overview]
Message-ID: <4880D995.4010606@trash.net> (raw)
In-Reply-To: <4880A611.76E4.0078.0@novell.com>

Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> 
> ---
>  net/ipv4/netfilter/nf_nat_snmp_basic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c	2008-07-13 23:51:29.000000000 +0200
> +++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c	2008-07-15 14:51:28.000000000 +0200
> @@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
>  	size = eoc - ctx->pointer + 1;
>  
>  	/* first subid actually encodes first two subids */
> -	if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
> +	if (size < 2 || size > UINT_MAX/sizeof(unsigned long))

Thanks, I already have a similar fix queued.

      reply	other threads:[~2008-07-18 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 12:17 [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s Jan Beulich
2008-07-18 17:57 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4880D995.4010606@trash.net \
    --to=kaber@trash.net \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox