* [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s
@ 2008-07-18 12:17 Jan Beulich
2008-07-18 17:57 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2008-07-18 12:17 UTC (permalink / raw)
To: kaber; +Cc: linux-kernel, netfilter-devel
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-15 14:51:28.000000000 +0200
@@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
size = eoc - ctx->pointer + 1;
/* first subid actually encodes first two subids */
- if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
+ if (size < 2 || size > UINT_MAX/sizeof(unsigned long))
return 0;
*oid = kmalloc(size * sizeof(unsigned long), GFP_ATOMIC);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s
2008-07-18 12:17 [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s Jan Beulich
@ 2008-07-18 17:57 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-07-18 17:57 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-kernel, netfilter-devel
Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-13 23:51:29.000000000 +0200
> +++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-15 14:51:28.000000000 +0200
> @@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
> size = eoc - ctx->pointer + 1;
>
> /* first subid actually encodes first two subids */
> - if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
> + if (size < 2 || size > UINT_MAX/sizeof(unsigned long))
Thanks, I already have a similar fix queued.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-18 12:17 [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s Jan Beulich
2008-07-18 17:57 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox