* [PATCH] x86: reduce force_mwait visibility
@ 2008-07-18 12:45 Jan Beulich
2008-07-18 22:55 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2008-07-18 12:45 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
It's not used anywhere outside its single referencing file.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/cpu/amd.c | 2 --
arch/x86/kernel/process.c | 2 ++
include/asm-x86/processor.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
--- linux-2.6.26/arch/x86/kernel/cpu/amd.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/arch/x86/kernel/cpu/amd.c 2008-07-15 14:54:53.000000000 +0200
@@ -61,8 +61,6 @@ static __cpuinit int amd_apic_timer_brok
}
#endif
-int force_mwait __cpuinitdata;
-
static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
{
if (cpuid_eax(0x80000000) >= 0x80000007) {
--- linux-2.6.26/arch/x86/kernel/process.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/arch/x86/kernel/process.c 2008-07-15 14:54:53.000000000 +0200
@@ -122,6 +122,8 @@ static void poll_idle(void)
*
* idle=mwait overrides this decision and forces the usage of mwait.
*/
+static int __cpuinitdata force_mwait;
+
static int __cpuinit mwait_usable(const struct cpuinfo_x86 *c)
{
if (force_mwait)
--- linux-2.6.26/include/asm-x86/processor.h 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/include/asm-x86/processor.h 2008-07-15 14:54:53.000000000 +0200
@@ -727,8 +727,6 @@ static inline void __sti_mwait(unsigned
extern void mwait_idle_with_hints(unsigned long eax, unsigned long ecx);
-extern int force_mwait;
-
extern void select_idle_routine(const struct cpuinfo_x86 *c);
extern unsigned long boot_option_idle_override;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: reduce force_mwait visibility
2008-07-18 12:45 [PATCH] x86: reduce force_mwait visibility Jan Beulich
@ 2008-07-18 22:55 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2008-07-18 22:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: mingo, tglx, linux-kernel
Jan Beulich wrote:
> It's not used anywhere outside its single referencing file.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
Manually applied to x86/cleanups, thanks.
-hpa
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-18 12:45 [PATCH] x86: reduce force_mwait visibility Jan Beulich
2008-07-18 22:55 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).