From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754697AbYGSKSc (ORCPT ); Sat, 19 Jul 2008 06:18:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753173AbYGSKSP (ORCPT ); Sat, 19 Jul 2008 06:18:15 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:60376 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752833AbYGSKSO (ORCPT ); Sat, 19 Jul 2008 06:18:14 -0400 Message-ID: <4881BEF4.2020201@cn.fujitsu.com> Date: Sat, 19 Jul 2008 18:16:20 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Andrew Morton CC: Al Viro , LKML Subject: [PATCH] vfs: use kstrdup() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This piece of code can be replaced by a kstrdup(). Signed-off-by: Li Zefan --- fs/namespace.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 4f6f763..08c3b2d 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -127,14 +127,7 @@ struct vfsmount *alloc_vfsmnt(const char *name) INIT_LIST_HEAD(&mnt->mnt_slave_list); INIT_LIST_HEAD(&mnt->mnt_slave); atomic_set(&mnt->__mnt_writers, 0); - if (name) { - int size = strlen(name) + 1; - char *newname = kmalloc(size, GFP_KERNEL); - if (newname) { - memcpy(newname, name, size); - mnt->mnt_devname = newname; - } - } + mnt->mnt_devname = kstrdup(name, GFP_KERNEL); } return mnt; } -- 1.5.4.rc3