Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC

Alan Jenkins
2008-07-17T19:07:23Z

Henrique de Moraes Holschuh wrote:
> On Thu, 17 Jul 2008, Alan Jenkins wrote:
>
>> Actually Alexey has another patch in bugzilla (#10919) which resolves
>> this issue in a better way. It avoids polling altogether, which is good
>> because it means you get events immediately. My laptop has backlight
>> adjustment hotkeys with hardware autorepeat, so it looks really jerky
>> with polling.
>>
>
> We need to get ALL pending events from the EC, whether in polling mode or in
> interrupt mode

> (and we must make sure that we ARE going to queue any new
> interrupt before we stop checking for an empty pending event queue,
> otherwise there is a small window where a new event might get queued, and we
> are still masking the GPE and don't notice it). As long as the fix does
> that, it is all I care :-)
>
OK, I forgot about that. I need to do some reading on kernel
programming, workqueues in particular, and redo my patch again. Sorry,
Alexey! AFAICS there's still this (very) small window where events could
be dropped.

Alan