* [PATCH 2/2] xen: don't use sysret for sysexit32
@ 2008-07-21 23:49 Jeremy Fitzhardinge
2008-07-24 10:29 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2008-07-21 23:49 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Mark McLoughlin, Eduardo Habkost, Linux Kernel Mailing List
When implementing sysexit32, don't let Xen use sysret to return to
userspace. That results in usermode register state being trashed.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
arch/x86/xen/xen-asm_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
===================================================================
--- a/arch/x86/xen/xen-asm_64.S
+++ b/arch/x86/xen/xen-asm_64.S
@@ -173,7 +173,7 @@
pushq $__USER32_CS
pushq %rdx
- pushq $VGCF_in_syscall
+ pushq $0
1: jmp hypercall_iret
ENDPATCH(xen_sysexit)
RELOC(xen_sysexit, 1b+1)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] xen: don't use sysret for sysexit32
2008-07-21 23:49 [PATCH 2/2] xen: don't use sysret for sysexit32 Jeremy Fitzhardinge
@ 2008-07-24 10:29 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-24 10:29 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Mark McLoughlin, Eduardo Habkost, Linux Kernel Mailing List
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> When implementing sysexit32, don't let Xen use sysret to return to
> userspace. That results in usermode register state being trashed.
applied to tip/x86/urgent, thanks Jeremy.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-24 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 23:49 [PATCH 2/2] xen: don't use sysret for sysexit32 Jeremy Fitzhardinge
2008-07-24 10:29 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox