From: roel kluin <roel.kluin@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] auditsc: test below 0 on unsigned ino
Date: Mon, 21 Jul 2008 20:29:16 -0400 [thread overview]
Message-ID: <488529DC.2030504@gmail.com> (raw)
ino is unsigned so the test didn't work.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index c10e7aa..dc8e0a4 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -286,7 +286,7 @@ static int audit_match_filetype(struct audit_context *ctx, int which)
mode_t mode = which & S_IFMT;
if (index >= ctx->name_count)
return 0;
- if (ctx->names[index].ino == -1)
+ if (ctx->names[index].ino == -1ul)
return 0;
if ((ctx->names[index].mode ^ mode) & S_IFMT)
return 0;
next reply other threads:[~2008-07-22 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 0:29 roel kluin [this message]
2008-07-22 2:13 ` [PATCH 4/9] auditsc: test below 0 on unsigned ino Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488529DC.2030504@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox