From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B72376BD3 for ; Thu, 23 Apr 2026 11:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776944087; cv=none; b=AiuAO8tcT1d5AHsxWNx4lTKgw3VIno3Oo9twzzEuXjjwWaQ/GH6zIqpPASAtX0xzgWNUxNAYzTxJlll+OduSHoyKBj04E2eqlzt+uRqSAKYysWvjYpdWfAphKX+vqc6pupQvMZtXkxSuGwRCk8InrZ9I6deYloBmCyRzqp3gvKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776944087; c=relaxed/simple; bh=0WfnOZbXeCCnN3w3UE+Jw0ce/6J+iDbqFJsV/ehYRCw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YftDWhnMZYWsPI6PJvTUDvK0RUwCFms5Htzk8xvUO1LJZ0NdWAE9kDMoRjE6hasLyoc0yqSeNJc5MieEV9rn7TRZ9+byu3Lf8vswXI37GGszCOBXraHMFPo6kYR+IguPuW0avEboU/XpWQtN8yU2SDJ8gBaflHBj9qfcfRUw0as= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eFN/luxW; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eFN/luxW" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so106891045e9.2 for ; Thu, 23 Apr 2026 04:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776944084; x=1777548884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0WfnOZbXeCCnN3w3UE+Jw0ce/6J+iDbqFJsV/ehYRCw=; b=eFN/luxW+aGDZZH66Ri2eaFyiP+8c8eaR4DjtZnGdI6OYF6Wj/Y8iDh3ObzaA/8sV9 wVy656szM5Q4qx0qjp0zjqde7b+FZY7gimuh4FopS09ng8IKrxi9AZA3oHJP4xwwHEKd oZH5UHlpc2h7LxRlqOnHnniGyto+3TtGp+dBVMKXaCxHmrXT5D927vsjMPjsUuH6o6Tl eolDVpQwCPJVHSERsZsZKAHko70h0rJlFPfDymc44t2rEAEN4MG7dC+GWGjmrSCmB1jc 6+G0SBwQIjMY6LPLeIhlLIImTDTuK7MSu5epJX8KJNTu5KbbgIzWluX2l7EnWwrl15NX h2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776944084; x=1777548884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0WfnOZbXeCCnN3w3UE+Jw0ce/6J+iDbqFJsV/ehYRCw=; b=NCgLF0csFVbEaiNObV6b0JDPibG8kqvo9+Uyb5c3BTsrpDDlaR0SGjEVdbc5P3yPv1 Pc35JgCR47L1iwzVnYkDI+5YVNOYn4VzpfxoxczEYTIkua5uLGZTtPXUAP6WDPpxbER7 mVQ8FJoqWoa3jhuNLjTyKMK90Ssu5bB+bTmKEuGPdHZOtRNXpHHGSeNAjgqq/wsLgvhs DLK5+jf06h86X5dnPRQYTIaGG8mP8oTz2tU0gHn7OpcmCPuV5nK2zsAgd8gUado1oZTH 3OKaafs43+23euzKLHTxjPJ3JABQMctEEgBr3RQtoWErjU1+gqkGLY8ekUz4vT4jbVOy PqQg== X-Forwarded-Encrypted: i=1; AFNElJ/cToB/ayzyckl6RtAapxwAS9ESPI2F+VKqR1UNDfG72F+N5LHDSYLZBk/5VoboyJ1IStNGTZeBwrzRNEk=@vger.kernel.org X-Gm-Message-State: AOJu0YwDOF4JRIlwFo2ka3n08KfSC5pxr/12AD0yZjK93WKo7tz2MgEp /Mobgl/m4yB9XW7AT3rHCPhyua/b+ux6hDDB1Rjffp4HNWHfo1pGqm0p X-Gm-Gg: AeBDievBXIrxOCh6BDI4SA3UjYHVp2mMvAp97GNzxXINqlgiGVYK+Aqu76zN8Mnh2c6 Wax7x9RHVJbgmw/2OorDwAi8JggSjU191kuQpHdP9bt/e3xGIK+S8eCisifyj4VO2PB+jdFbPuf /MLumA67CKHwFgfVMfMR4aJltY7fuDYuP4iN3JEZQTW5Rh8yySJmxTTs1S/m/lnJ7Qrzuk0Udl/ KUIFIEvwqGG0He+Y40UIskyVQnyMa03JQmGcRbEOP0mzMTset1FbRuzgc8QP45owotHlTvp2ATI 8O1KzBDQQqseoctQpQ4UiMCkgq5HjxEVz4GJGBO2Jy7rOG4/RULJwwiC/FDWMTu7q2DJyWI6iwM QlVGDSr9kOWuqS7DKLsuPqin0ivDHSgZZvrxtTi0W164Ihj4varL1j/x/bDR8+yrOBOC9n8JPab slwua2oXVkc67XblR5L4oXhePGoAoMm5N7iHH1nHzK5OomBP3tG7AY6Cph4tatgVems1ebhq06s /bU7syRj8k= X-Received: by 2002:a05:600c:620d:b0:489:1d23:4524 with SMTP id 5b1f17b1804b1-4891d23468bmr239536185e9.5.1776944084219; Thu, 23 Apr 2026 04:34:44 -0700 (PDT) Received: from timur-hyperion.localnet (5E1B98A2.dsl.pool.telekom.hu. [94.27.152.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891c08faffsm552416145e9.1.2026.04.23.04.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 04:34:43 -0700 (PDT) From: Timur =?UTF-8?B?S3Jpc3TDs2Y=?= To: Christian =?UTF-8?B?S8O2bmln?= , Greg Kroah-Hartman Cc: stable@vger.kernel.org, Robert Garcia , Alex Deucher , Pan Xinhui , David Airlie , Daniel Vetter , Yifan Zha , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s Date: Thu, 23 Apr 2026 13:34:42 +0200 Message-ID: <4885687.vXUDI8C0e8@timur-hyperion> In-Reply-To: <2026042335-probation-heftiness-7399@gregkh> References: <20260417074010.1607496-1-rob_garcia@163.com> <6064b45a-b8de-4848-856f-383d2d06680d@amd.com> <2026042335-probation-heftiness-7399@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Thursday, April 23, 2026 1:22:22=E2=80=AFPM Central European Summer Time= Greg=20 Kroah-Hartman wrote: > On Wed, Apr 22, 2026 at 04:11:15PM +0200, Christian K=C3=B6nig wrote: > > Those points are certainly valid. > >=20 > > I've also up-streamed a patch which completely rejects userspace > > submissions who try to use the CE. > >=20 > > The problem is that those BUG_ON() can lead to a deny of service because > > they crash the whole kernel. > >=20 > > A BUG_ON() is only justified if it prevents even worse things to happen, > > e.g. data corruption or it would crash later on anyway just not so > > obvious on what is wrong. > >=20 > > Otherwise we should use WARN_ON(). >=20 > WARN_ON() crashes the kernel as well when panic-on-warn is enabled, as > it is in a few billion Linux systems :( >=20 > As this commit is upstream, and in other stable trees, I'll apply this > as it's not nice to have a simple way for userspace to crash the system. >=20 > thanks, >=20 > greg k-h Sounds reasonable, if you feel this improves stability. That being said, there are many other ways besides this one for userspace t= o=20 crash the system equally easily. Timur