public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] make pnp_build_option() static
@ 2008-07-22 17:20 Adrian Bunk
  2008-07-23 19:00 ` Bjorn Helgaas
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-07-22 17:20 UTC (permalink / raw)
  To: ambx1, Bjorn Helgaas, Rene Herman; +Cc: linux-kernel

pnp_build_optionq() can now become static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
87ec46ea755fc5349371bf2208b30264da355699 
diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
index 4cfe3a1..2e5b7eb 100644
--- a/drivers/pnp/resource.c
+++ b/drivers/pnp/resource.c
@@ -30,8 +30,9 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
  * option registration
  */
 
-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
-				    unsigned int option_flags)
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev,
+					   unsigned long type,
+					   unsigned int option_flags)
 {
 	struct pnp_option *option;
 


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make pnp_build_option() static
  2008-07-22 17:20 [2.6 patch] make pnp_build_option() static Adrian Bunk
@ 2008-07-23 19:00 ` Bjorn Helgaas
  2008-07-24  8:49   ` Andi Kleen
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2008-07-23 19:00 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: ambx1, Rene Herman, linux-kernel, Andi Kleen, Len Brown

On Tuesday 22 July 2008 11:20:21 am Adrian Bunk wrote:
> pnp_build_optionq() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

PNP patches have been going through the ACPI tree lately.
I copied Andi and Len.

> ---
> 87ec46ea755fc5349371bf2208b30264da355699 
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index 4cfe3a1..2e5b7eb 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -30,8 +30,9 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
>   * option registration
>   */
>  
> -struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> -				    unsigned int option_flags)
> +static struct pnp_option *pnp_build_option(struct pnp_dev *dev,
> +					   unsigned long type,
> +					   unsigned int option_flags)
>  {
>  	struct pnp_option *option;
>  
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make pnp_build_option() static
  2008-07-23 19:00 ` Bjorn Helgaas
@ 2008-07-24  8:49   ` Andi Kleen
  0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2008-07-24  8:49 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Adrian Bunk, ambx1, Rene Herman, linux-kernel, Len Brown

Bjorn Helgaas wrote:
> On Tuesday 22 July 2008 11:20:21 am Adrian Bunk wrote:
>> pnp_build_optionq() can now become static.
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> 
> PNP patches have been going through the ACPI tree lately.
> I copied Andi and Len.

Looks good thanks. I'm currently a bit behind with patches because
I'm at OLS and still focussing on patches for .27 only, but I'll
process all the post .27 patches soon.

-Andi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-24  8:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22 17:20 [2.6 patch] make pnp_build_option() static Adrian Bunk
2008-07-23 19:00 ` Bjorn Helgaas
2008-07-24  8:49   ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox