From: Martin Wilck <martin.wilck@fujitsu-siemens.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Wichert, Gerhard" <Gerhard.Wichert@fujitsu-siemens.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe
Date: Thu, 24 Jul 2008 17:13:24 +0200 [thread overview]
Message-ID: <48889C14.4070408@fujitsu-siemens.com> (raw)
In-Reply-To: <20080724150116.GC32422@lenovo>
Hi Cyrill,
> btw, Martin, don't get me wrong please - i'm not just complaining :)
> The changes you propose is important enough _but_ it could introduce
> regression. Look, with situation of miscalibrated apic timer kernel
> was working before but with the patch it could stop to work. So if
> user has a such screwed motherboard he could be shocked if it stop
> booting with message about SMI happened. we defenitely have to provide
> some workaround for this. And your max iteration counter solution
> would be fine I think.
Let's see what other people think about this. I am fine with both
solutions. Currently only the first one has been tested though (testing
these patches thoroughly needs long-time reboot tests).
One more remark: There are similar calibration routines around in the
kernel which suffer from similar problems as calibrate_APIC_clock().
AFAIK, only calibrate_delay() was made SMI-safe by Venkatesh Pallipadi
years ago.
Martin
--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DEV 6
Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn
Germany
Tel: ++49 5251 8 15113
Fax: ++49 5251 8 20209
Email: mailto:martin.wilck@fujitsu-siemens.com
Internet: http://www.fujitsu-siemens.com
Company Details: http://www.fujitsu-siemens.com/imprint.html
next prev parent reply other threads:[~2008-07-24 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 10:47 [PATCH] x86 (64): make calibrate_APIC_clock() smp-safe Martin Wilck
2008-07-24 11:16 ` Cyrill Gorcunov
2008-07-24 11:58 ` Martin Wilck
2008-07-24 12:05 ` Cyrill Gorcunov
2008-07-24 13:55 ` [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe Martin Wilck
2008-07-24 14:31 ` Cyrill Gorcunov
2008-07-24 15:01 ` Cyrill Gorcunov
2008-07-24 15:13 ` Martin Wilck [this message]
2008-07-25 9:02 ` [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe (take 2) Martin Wilck
2008-07-25 10:08 ` Cyrill Gorcunov
2008-07-25 12:29 ` Martin Wilck
2008-07-25 12:59 ` Cyrill Gorcunov
2008-07-25 13:38 ` Martin Wilck
2008-07-25 13:48 ` Cyrill Gorcunov
2008-07-25 14:01 ` [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe (take 3) Martin Wilck
2008-07-25 14:15 ` Cyrill Gorcunov
2008-07-25 15:01 ` Cyrill Gorcunov
2008-07-25 15:13 ` Martin Wilck
2008-07-25 15:39 ` Cyrill Gorcunov
2008-07-26 15:40 ` Ingo Molnar
2009-03-12 9:41 ` Jean Delvare
2009-03-12 13:38 ` Martin Wilck
2008-07-25 16:51 ` [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe (take 2) Olaf Dabrunz
2008-07-24 13:31 ` [PATCH] x86 (64): make calibrate_APIC_clock() smp-safe H. Peter Anvin
2008-07-24 13:42 ` [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48889C14.4070408@fujitsu-siemens.com \
--to=martin.wilck@fujitsu-siemens.com \
--cc=Gerhard.Wichert@fujitsu-siemens.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox