From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Xen: Use native_pte_flags instead of native_pte_val for .pte_flags
Date: Thu, 24 Jul 2008 08:44:13 -0700 [thread overview]
Message-ID: <4888A34D.8040607@goop.org> (raw)
In-Reply-To: <1216912546-6971-1-git-send-email-ehabkost@redhat.com>
Eduardo Habkost wrote:
> Using native_pte_val triggers the BUG_ON() in the paravirt_ops
> version of pte_flags().
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>
Good point.
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
J
> ---
> arch/x86/xen/enlighten.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 3fc0c15..6b169b7 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1378,7 +1378,7 @@ static const struct pv_mmu_ops xen_mmu_ops __initdata = {
> .ptep_modify_prot_commit = __ptep_modify_prot_commit,
>
> .pte_val = xen_pte_val,
> - .pte_flags = native_pte_val,
> + .pte_flags = native_pte_flags,
> .pgd_val = xen_pgd_val,
>
> .make_pte = xen_make_pte,
>
next prev parent reply other threads:[~2008-07-24 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 15:15 [PATCH 1/2] Xen: Use native_pte_flags instead of native_pte_val for .pte_flags Eduardo Habkost
2008-07-24 15:15 ` [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() Eduardo Habkost
2008-07-24 15:45 ` Jeremy Fitzhardinge
2008-07-24 18:30 ` Jeff Garzik
2008-07-24 18:39 ` Jeremy Fitzhardinge
2008-07-31 20:03 ` Eduardo Habkost
2008-07-31 20:09 ` Jeremy Fitzhardinge
2008-07-24 15:44 ` Jeremy Fitzhardinge [this message]
2008-07-26 15:49 ` [PATCH 1/2] Xen: Use native_pte_flags instead of native_pte_val for .pte_flags Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4888A34D.8040607@goop.org \
--to=jeremy@goop.org \
--cc=ehabkost@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox