Re: [PATCH v2] dmaengine: idxd: Remove redundant memset() for eventlog allocation

Dave Jiang
2023-08-29T18:12:19Z

On 8/29/23 11:00, coolrrsh@gmail.com wrote:
> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> dma_alloc_coherent function already zeroes the array 'addr'.
> So, memset function call is not needed.
>
> This fixes warning such as:
> drivers/dma/idxd/device.c:783:8-26:
> WARNING: dma_alloc_coherent used in addr already zeroes out memory,
> so memset is not needed.
>
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
> v1->v2
> Renamed the subject line
> ---
> drivers/dma/idxd/device.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..7c74bc60f582 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -786,8 +786,6 @@ static int idxd_device_evl_setup(struct idxd_device *idxd)
> goto err_alloc;
> }
>
> - memset(addr, 0, size);
> -
> spin_lock(&evl->lock);
> evl->log = addr;
> evl->dma = dma_addr;