From: roel kluin <roel.kluin@gmail.com>
To: mac@melware.de
Cc: linux-kernel@vger.kernel.org
Subject: isdn/eicon: msg_in_{wrap,read}_pos assigned twice?
Date: Fri, 25 Jul 2008 15:26:43 -0400 [thread overview]
Message-ID: <488A28F3.6030100@gmail.com> (raw)
vi drivers/isdn/hardware/eicon/message.c +4035
and note two similar tests on line 4035 and 4049:
[else] if (plci->msg_in_read_pos == plci->msg_in_wrap_pos)
after the first test:
plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
plci->msg_in_read_pos = i + MSG_IN_OVERHEAD;
but then after the second test as well:
plci->msg_in_read_pos = MSG_IN_QUEUE_SIZE;
plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
So the assignment after the first test has no effect. Is this a bug?
Roel Kluin
next reply other threads:[~2008-07-25 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 19:26 roel kluin [this message]
2008-07-28 14:41 ` isdn/eicon: msg_in_{wrap,read}_pos assigned twice? Armin Schindler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488A28F3.6030100@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox