From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Hugh Dickins <hugh@veritas.com>, Jack Steiner <steiner@sgi.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] x86_64: Optimize percpu accesses
Date: Fri, 25 Jul 2008 17:30:57 -0700 [thread overview]
Message-ID: <488A7041.5070802@goop.org> (raw)
In-Reply-To: <488A6F5F.5000105@sgi.com>
Mike Travis wrote:
> Yes, you're right, I wrote that quickly without really reading it back.
> My point is that now that x86_read_percpu() and x86_write_percpu() do
> evaluate to a single instruction (by definition atomic), then it doesn't
> need to be surrounded by the preempt_disable()/preempt_enable() calls.
>
Yep, correct.
> It appears as if I'm implying that's the case for get/put_cpu_var().
>
Right.
J
next prev parent reply other threads:[~2008-07-26 0:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 21:11 [PATCH 0/4] x86_64: Optimize percpu accesses Mike Travis
2008-07-25 21:11 ` [PATCH 1/4] x86_64: Cleanup early setup_percpu references Mike Travis
2008-07-25 21:11 ` [PATCH 2/4] x86_64: Base percpu variables at zero Mike Travis
2008-07-25 21:11 ` [PATCH 3/4] x86_64: Fold pda into per cpu area Mike Travis
2008-07-25 21:11 ` [PATCH 4/4] x86_64: Reference zero-based percpu variables offset from gs Mike Travis
2008-07-25 23:26 ` [PATCH 0/4] x86_64: Optimize percpu accesses Jeremy Fitzhardinge
2008-07-26 0:27 ` Mike Travis
2008-07-26 0:30 ` Jeremy Fitzhardinge [this message]
2008-07-26 12:38 ` Ingo Molnar
2008-07-28 18:33 ` Mike Travis
2008-07-28 15:52 ` [crash] " Ingo Molnar
2008-07-28 19:39 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488A7041.5070802@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox