* [PATCH] cgroup: uninline cgroup_has_css_refs()
@ 2008-07-28 2:21 Li Zefan
2008-07-30 10:37 ` Paul Menage
0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2008-07-28 2:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: Paul Menage, LKML, Linux Containers
It's not small enough, and has 2 call sites.
text data bss dec hex filename
12813 1676 4832 19321 4b79 cgroup.o.orig
12775 1676 4832 19283 4b53 cgroup.o
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cgroup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 249a517..13932ab 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2368,7 +2368,7 @@ static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, int mode)
return cgroup_create(c_parent, dentry, mode | S_IFDIR);
}
-static inline int cgroup_has_css_refs(struct cgroup *cgrp)
+static int cgroup_has_css_refs(struct cgroup *cgrp)
{
/* Check the reference count on each subsystem. Since we
* already established that there are no tasks in the
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cgroup: uninline cgroup_has_css_refs()
2008-07-28 2:21 [PATCH] cgroup: uninline cgroup_has_css_refs() Li Zefan
@ 2008-07-30 10:37 ` Paul Menage
0 siblings, 0 replies; 2+ messages in thread
From: Paul Menage @ 2008-07-30 10:37 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, LKML, Linux Containers
On Sun, Jul 27, 2008 at 7:21 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> It's not small enough, and has 2 call sites.
>
> text data bss dec hex filename
> 12813 1676 4832 19321 4b79 cgroup.o.orig
> 12775 1676 4832 19283 4b53 cgroup.o
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
I'm not sure that saving 38 bytes is worth the tiny slowdown this
might introduce, but I guess it doesn't hurt much either way.
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-30 10:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-28 2:21 [PATCH] cgroup: uninline cgroup_has_css_refs() Li Zefan
2008-07-30 10:37 ` Paul Menage
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox