[PATCH] memcg: remove redundant check in move_task()

[PATCH] memcg: remove redundant check in move_task()

[Li Zefan]

It's guaranteed by cgroup that old_cgrp != cgrp.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 mm/memcontrol.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index fba566c..7056c3b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1168,9 +1168,6 @@ static void mem_cgroup_move_task(struct cgroup_subsys *ss,
 	mem = mem_cgroup_from_cont(cont);
 	old_mem = mem_cgroup_from_cont(old_cont);
 
-	if (mem == old_mem)
-		goto out;
-
 	/*
 	 * Only thread group leaders are allowed to migrate, the mm_struct is
 	 * in effect owned by the leader
-- 
1.5.4.rc3

Re: [PATCH] memcg: remove redundant check in move_task()

[KAMEZAWA Hiroyuki]

On Mon, 28 Jul 2008 10:28:27 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> It's guaranteed by cgroup that old_cgrp != cgrp.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Thank you. 
Hmm.. I like BUG_ON() to show that "this will never happen" rather
than just removing.

Anyway. I ack this.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

> ---
>  mm/memcontrol.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fba566c..7056c3b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1168,9 +1168,6 @@ static void mem_cgroup_move_task(struct cgroup_subsys *ss,
>  	mem = mem_cgroup_from_cont(cont);
>  	old_mem = mem_cgroup_from_cont(old_cont);
>  
> -	if (mem == old_mem)
> -		goto out;
> -
>  	/*
>  	 * Only thread group leaders are allowed to migrate, the mm_struct is
>  	 * in effect owned by the leader
> -- 
> 1.5.4.rc3
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>