From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759751AbYG1Sqq (ORCPT ); Mon, 28 Jul 2008 14:46:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753511AbYG1Sqg (ORCPT ); Mon, 28 Jul 2008 14:46:36 -0400 Received: from relay2.sgi.com ([192.48.171.30]:38385 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752773AbYG1Sqg (ORCPT ); Mon, 28 Jul 2008 14:46:36 -0400 Message-ID: <488E140B.1080205@sgi.com> Date: Mon, 28 Jul 2008 11:46:35 -0700 From: Mike Travis User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Rusty Russell CC: Linus Torvalds , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton Subject: Re: [git pull] cpus4096 fixes References: <20080727190601.GA764@elte.hu> <200807281042.12860.rusty@rustcorp.com.au> In-Reply-To: <200807281042.12860.rusty@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rusty Russell wrote: > On Monday 28 July 2008 06:15:26 Linus Torvalds wrote: >> On Sun, 27 Jul 2008, Ingo Molnar wrote: >>> Please pull the latest cpus4096-fixes git tree from: >> No. Not without explanations. >> >> Quite frankly, this "fix" looks like a huge stinking pile of sh*t. >> >> I can't follow that thread on lkml.org (horrible web interface with >> hard-to-follow threading), and I'm too lazy to bother to look in my lkml >> email archives, but whoever said >> >> "The simple version is just a static array of [NR_CPUS] cpumask_t's." >> >> and then implemented this piece of shit is a complete and utter moron. > > How awesome, Linus is talking about me! > > Your idea is clever, thanks. This patch was a bandaid to save us from the > unbearably fugly "cpumask_of_cpu_ptr_declare(cpu_mask)". I was going to rip > this code out as soon as possible, but with your trick we should keep it. > > The 4k CPU patches have been sliding in without review up until now. We need > a serious think about how to handle cpumask_t that doesn't fit on the stack. > > Hey, since Mike put his Signed-off-by above mine and didn't put a From line > when he took my patch, WFT am I taking responsibility? :) > > Rusty. Just so I don't make the same mistake, this: Signed-off-by: Rusty Russell Signed-off-by: Mike Travis Should have been this: From: Rusty Russell Signed-off-by: Rusty Russell Signed-off-by: Mike Travis ? Thanks, Mike