From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Cliff Wickman <cpw@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Comments on UV tlb flushing
Date: Mon, 28 Jul 2008 17:28:59 -0700 [thread overview]
Message-ID: <488E644B.10801@goop.org> (raw)
I'm just reworking the x86 tlb code to use smp_call_function_mask, and I
see how the UV tlb flushing hooks in. A few things occur to me:
1. There should be a CONFIG_X86_UV to select this code. tlb_uv.o is
around 6k, which is not trivial overhead to subject every x86_64
kernel to.
2. CONFIG_X86_UV should either depend on or select CONFIG_PARAVIRT.
3. You should hook into paravirt_ops to enable your tlb-flush code.
That is, in - say - uv_bau_init() you do
"pv_mmu_ops.flush_tlb_others = uv_flush_tlb_others". This removes
a test/branch in the generic code. Using paravirt_ops may open
other opportunities to put UV-optimised functions in place without
having to modify generic code.
My understanding is that the UV hardware has some kind of
payload-carrying IPI mechanism, which is a capability could be useful to
express in a higher-level way in the kernel. Certainly I could imagine
using it in a virtual environment as a way to do inter-VCPU messaging
with less context switch overhead.
Thanks,
J
next reply other threads:[~2008-07-29 0:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 0:28 Jeremy Fitzhardinge [this message]
2008-07-29 4:12 ` Comments on UV tlb flushing Nick Piggin
2008-07-29 6:26 ` Jeremy Fitzhardinge
2008-07-29 13:32 ` Cliff Wickman
2008-07-29 14:43 ` Jeremy Fitzhardinge
2008-07-29 17:34 ` Cliff Wickman
2008-07-29 17:46 ` Jeremy Fitzhardinge
2008-07-29 20:04 ` Cliff Wickman
2008-07-29 18:13 ` Yinghai Lu
2008-07-29 18:25 ` Jeremy Fitzhardinge
2008-07-29 18:45 ` Mike Travis
2008-07-29 19:12 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488E644B.10801@goop.org \
--to=jeremy@goop.org \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox