public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Andi Kleen <andi@firstfloor.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 0/4] unify arch/x86/kernel/tlb.c
Date: Tue, 29 Jul 2008 01:05:30 -0700	[thread overview]
Message-ID: <488ECF4A.6080200@goop.org> (raw)

This series converts tlb_32.c and _64.c to use smp_call_function_mask.  
Having done that, their underlying similarity is plainly revealed, and 
they can be easily unified.

The result is the removal of ~270 lines of code, most of which was a 
pair of open-coded versions of what smp_call_function_mask does anyway.  
The remaining code is much clearer as a result.

I've given these patches some mild testing, and nothing exploded.  I'm 
actually fairly confident in them, since all the complex subtle stuff is 
now in smp_call_function_mask, so if anything breaks, it's probably 
going to be in there.

And though I dare not touch it, Voyager could probably be converted to 
use this code fairly simply as well.

    J

--
 arch/x86/kernel/Makefile      |    2 
 arch/x86/kernel/entry_64.S    |   15 --
 arch/x86/kernel/irqinit_64.c  |   10 -
 arch/x86/kernel/tlb.c         |  229 ++++++++++++++++++++++++++++++++++
 arch/x86/kernel/tlb_32.c      |  191 ----------------------------
 arch/x86/kernel/tlb_64.c      |  279 ------------------------------------------
 arch/x86/kernel/tlb_uv.c      |    5 
 include/asm-x86/irq_vectors.h |    4 
 include/asm-x86/uv/uv_bau.h   |    2 
 9 files changed, 234 insertions(+), 503 deletions(-)



                 reply	other threads:[~2008-07-29  8:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488ECF4A.6080200@goop.org \
    --to=jeremy@goop.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox