public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tim Bird <tim.bird@am.sony.com>
To: Grant Coady <gcoady.lk@gmail.com>
Cc: Marco Berizzi <pupilla@hotmail.com>,
	Alistair John Strachan <alistair@devzero.co.uk>,
	linux-kernel@vger.kernel.org, dwmw2@infradead.org
Subject: Re: commit a29ccf6f823a84d89e1c7aaaf221cf7282022024 break console on slackware 12.1
Date: Wed, 30 Jul 2008 13:11:50 -0700	[thread overview]
Message-ID: <4890CB06.9040106@am.sony.com> (raw)
In-Reply-To: <ntcv845p7kpiob7iqf6d1m8buj116ug4nv@4ax.com>

Grant Coady wrote:
> I have the same issue, the line drawing characters are displayed as an odd 
> looking C with a tail.  Slackware-12.1 and Slamd64-12.1.
> 
> .configs:
>   http://bugsplatter.mine.nu/test/boxen/pooh/config-2.6.27-rc1a.gz
>   http://bugsplatter.mine.nu/test/boxen/pooh64/config-2.6.27-rc1a.gz
> 
> CONFIG_CONSOLE_TRANSLATIONS=y ?? yes it's on

This looks like an operator precedence bug introduced by
the patch.

Normally I would test this myself before sending it out, but
I can't test 2.6.27-rc1 right now on my hardware due to another
bug in the 2.6.27-rc1 tree.

Can you please try the following patch and let me know if that
fixes the problem?

Thanks,
 -- Tim

diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
index 14c0e91..8c8119f 100644
--- a/include/linux/vt_kern.h
+++ b/include/linux/vt_kern.h
@@ -74,7 +74,7 @@ void con_protect_unimap(struct vc_data *vc, int rdonly);
 int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc);

 #define vc_translate(vc, c) ((vc)->vc_translate[(c) |			\
-					(vc)->vc_toggle_meta ? 0x80 : 0])
+					((vc)->vc_toggle_meta ? 0x80 : 0)])
 #else
 #define con_set_trans_old(arg) (0)
 #define con_get_trans_old(arg) (-EINVAL)




  reply	other threads:[~2008-07-30 20:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29 15:42 commit a29ccf6f823a84d89e1c7aaaf221cf7282022024 break console on slackware 12.1 Marco Berizzi
2008-07-29 17:15 ` Alistair John Strachan
2008-07-29 18:57   ` Marco Berizzi
2008-07-30  0:03     ` Tim Bird
2008-07-30  0:30       ` Grant Coady
2008-07-30 20:11         ` Tim Bird [this message]
2008-07-30 23:47           ` Grant Coady
2008-07-31 11:02           ` Marco Berizzi
2008-07-30 21:54         ` Rene Herman
2008-07-30 23:40           ` Grant Coady
2008-07-30  1:16       ` Grant Coady
2008-07-30  6:36         ` Marco Berizzi
2008-07-30 14:06       ` [RFT: 2.6 patch] fix text console corruptions Adrian Bunk
2008-07-30 15:24         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4890CB06.9040106@am.sony.com \
    --to=tim.bird@am.sony.com \
    --cc=alistair@devzero.co.uk \
    --cc=dwmw2@infradead.org \
    --cc=gcoady.lk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pupilla@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox