Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code

Jeff Garzik
2008-07-30T21:24:20Z

Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The mutex is released on a successful return, so it would seem that it
> should be released on an error return as well.
>
> The semantic patch finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression l;
> @@
>
> mutex_lock(l);
> ... when != mutex_unlock(l)
> when any
> when strict
> (
> if (...) { ... when != mutex_unlock(l)
> + mutex_unlock(l);
> return ...;
> }
> |
> mutex_unlock(l);
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>

applied