From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758245AbYGaCZB (ORCPT ); Wed, 30 Jul 2008 22:25:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752300AbYGaCYw (ORCPT ); Wed, 30 Jul 2008 22:24:52 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:52594 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752246AbYGaCYv (ORCPT ); Wed, 30 Jul 2008 22:24:51 -0400 Message-ID: <489121F8.2020008@cn.fujitsu.com> Date: Thu, 31 Jul 2008 10:22:48 +0800 From: Lai Jiangshan User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Andrew Morton CC: Paul Jackson , Paul Menage , Hidetoshi Seto , Li Zefan , Linux Kernel Mailing List Subject: [PATCH] cpuset: Add comments for update_domain_attr_tree Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add comments for update_domain_attr_tree(). Signed-off-by: Lai Jiangshan --- diff --git a/kernel/cpuset.c b/kernel/cpuset.c index adf66c0..fed1f42 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -487,15 +487,21 @@ update_domain_attr(struct sched_domain_attr *dattr, struct cpuset *c) { if (dattr->relax_domain_level < c->relax_domain_level) dattr->relax_domain_level = c->relax_domain_level; - return; } +/* + * Helper routine for rebuild_sched_domains(). + * Walk the specified cpuset subtree and update @dattr with the + * largest relax_domain_level. + * + * Called with cgroup_mutex held. + */ static void -update_domain_attr_tree(struct sched_domain_attr *dattr, struct cpuset *c) +update_domain_attr_tree(struct sched_domain_attr *dattr, struct cpuset *root) { LIST_HEAD(q); - list_add(&c->stack_list, &q); + list_add(&root->stack_list, &q); while (!list_empty(&q)) { struct cpuset *cp; struct cgroup *cont;