Re: [PATCH RFC] USB: Add HCD fastboot

Alan Stern
2008-08-06T19:49:38Z

On Wed, 6 Aug 2008, Simon Arlott wrote:

> > Wouldn't it be much simpler, and less objectionable, to do what I
> > suggested earlier? That is, add a 5-second delay at the start of
> > hub_thread() in drivers/usb/core/hub.c. No messing with Makefiles, no
> > changes to the initcall scheduling.
>
> Aside from 5 seconds being too long, and anything less being a race between
> hub_thread() and driver initcalls, it doesn't improve anything because it'll
> still have to wait for the devices to finish initialising in userspace instead.

Why is 5 seconds too long? Too long for what?

What you're doing is already a race between hub_thread() and driver
initcalls. My suggestion is no worse.

"it'll still have to wait..." If by "it" you mean the initcall
thread, you're wrong. If by "it" you mean the user, you still aren't
necessarily correct; the user can do plenty of other things while
waiting for USB devices to initialize.

I suppose you could make the hub_thread delay time a module parameter
for usbcore, defaulting to 0. Then it could be set by just the people
who want to use it -- many (most?) people keep their drivers in
modules, and it wouldn't do them any good.

Alan Stern