From: Max Krasnyansky <maxk@qualcomm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Peter Oruba <peter.oruba@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 0/4] x86: AMD microcode patch loading v2 fixes
Date: Thu, 31 Jul 2008 19:23:09 -0700 [thread overview]
Message-ID: <4892738D.5040703@qualcomm.com> (raw)
In-Reply-To: <20080731212441.GF2729@elte.hu>
Ingo Molnar wrote:
> * Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:
>
>> I've even suggested to consider doing microcode update somewhere
>> earlier in start_secondary() (say, right before cpu_idle()). So it'd
>> be done as ealry as possible + we don't mess up with cpu-hotplug
>> events.
>
> i have no problems with that approach in principle. Microcode updates
> are special and black magic things anyway.
>
I still think we should just do the update via schedule_work_on() and be
done with it. Maybe in theory it should be done as early as possible but
in practice hotplug handler -> workqueue will be soon enough, I think.
Max
next prev parent reply other threads:[~2008-08-01 2:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 15:41 [patch 0/4] x86: AMD microcode patch loading v2 fixes Peter Oruba
2008-07-29 15:41 ` [patch 1/4] x86: AMD microcode patch loader style corrections Peter Oruba
2008-07-29 15:41 ` [patch 2/4] x86: Intel " Peter Oruba
2008-07-29 15:41 ` [patch 3/4] x86: Moved function declarations out from AMD microcode patch loader to heade file Peter Oruba
2008-07-29 15:41 ` [patch 4/4] x86: Minor pointer type cast in AMD microcode patch loader Peter Oruba
2008-07-29 16:18 ` [patch 0/4] x86: AMD microcode patch loading v2 fixes Dmitry Adamushko
2008-07-29 17:49 ` Max Krasnyansky
2008-07-29 19:37 ` Dmitry Adamushko
2008-07-30 9:28 ` Peter Oruba
2008-07-30 9:57 ` Dmitry Adamushko
2008-07-30 10:34 ` Dmitry Adamushko
2008-07-30 16:35 ` Max Krasnyansky
2008-07-30 18:38 ` Dmitry Adamushko
2008-07-31 21:24 ` Ingo Molnar
2008-08-01 2:23 ` Max Krasnyansky [this message]
2008-07-30 16:54 ` Max Krasnyansky
2008-07-30 20:59 ` Dmitry Adamushko
2008-08-01 2:18 ` Max Krasnyansky
2008-08-01 11:25 ` Dmitry Adamushko
2008-08-01 12:21 ` Peter Oruba
2008-08-01 15:26 ` H. Peter Anvin
2008-07-31 21:27 ` Ingo Molnar
2008-07-31 22:02 ` Dmitry Adamushko
2008-07-31 22:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892738D.5040703@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.oruba@amd.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox