From: "H. Peter Anvin" <hpa@zytor.com>
To: Russ Anderson <rja@sgi.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
Jack Steiner <steiner@sgi.com>
Subject: Re: x86 BIOS interface for partitioning and system serial number on SGI UV
Date: Fri, 01 Aug 2008 10:34:30 -0700 [thread overview]
Message-ID: <48934926.2010200@zytor.com> (raw)
In-Reply-To: <20080731195753.GB25715@sgi.com>
Russ Anderson wrote:
> x86 BIOS interface for partitioning and system serial number on SGI UV
> - if (!proc_mkdir("sgi_uv", NULL))
> + if (!sgi_uv_dir)
> + sgi_uv_dir = proc_mkdir("sgi_uv", NULL);
> + if (!sgi_uv_dir)
> return -EINVAL;
This really seems more that it should belong in sysfs --
/sys/class/firmware presumably.
> +# define BIOS_CALL(result, a0, a1, a2, a3, a4, a5, a6, a7) \
> + do { \
> + /* XXX - the real call goes here */ \
> + result.status = BIOS_STATUS_UNIMPLEMENTED; \
> + result.v0 = 0; \
> + result.v1 = 0; \
> + } while (0)
I have more than a little problem with submitting patches like this. We
have no way to judge the suitability of the coding or the interface with
the "meat" of the driver stubbed out!
-hpa
next prev parent reply other threads:[~2008-08-01 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 19:57 x86 BIOS interface for partitioning and system serial number on SGI UV Russ Anderson
2008-08-01 17:34 ` H. Peter Anvin [this message]
2008-08-04 22:19 ` Russ Anderson
2008-08-05 0:50 ` H. Peter Anvin
2008-08-05 0:59 ` H. Peter Anvin
2008-08-05 3:54 ` Greg KH
2008-08-05 16:32 ` Russ Anderson
2008-08-05 16:53 ` Greg KH
2008-08-05 19:22 ` Russ Anderson
2008-08-05 23:06 ` Russ Anderson
2008-08-05 5:21 ` Kyle Moffett
2008-08-05 14:35 ` Mike Travis
2008-08-05 15:40 ` H. Peter Anvin
2008-08-05 15:56 ` Mike Travis
-- strict thread matches above, loose matches on Subject: below --
2008-08-05 17:24 H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48934926.2010200@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rja@sgi.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox