From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756822AbbICPlh (ORCPT ); Thu, 3 Sep 2015 11:41:37 -0400 Received: from mail.efficios.com ([78.47.125.74]:42730 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbbICPlf (ORCPT ); Thu, 3 Sep 2015 11:41:35 -0400 Date: Thu, 3 Sep 2015 15:41:22 +0000 (UTC) From: Mathieu Desnoyers To: Helge Deller Cc: Andrew Morton , linux-api , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-parisc@vger.kernel.org Message-ID: <489367754.35882.1441294882117.JavaMail.zimbra@efficios.com> In-Reply-To: References: <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com> <1440698215-8355-10-git-send-email-mathieu.desnoyers@efficios.com> Subject: Re: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [78.47.125.74] X-Mailer: Zimbra 8.6.0_GA_1178 (ZimbraWebClient - FF40 (Linux)/8.6.0_GA_1178) Thread-Topic: parisc: allocate sys_membarrier system call number Thread-Index: QXFoKyINooj9TaGVPROn6QoATsnjbw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Sep 3, 2015, at 8:26 AM, Helge Deller deller@gmx.de wrote: > Hi Mathieu, > >> [ Untested on this architecture. To try it out: fetch linux-next/akpm, >> apply this patch, build/run a membarrier-enabled kernel, and do make >> kselftest. ] >> >> Signed-off-by: Mathieu Desnoyers >> CC: Andrew Morton >> CC: linux-api@vger.kernel.org >> CC: "James E.J. Bottomley" >> CC: Helge Deller >> CC: linux-parisc@vger.kernel.org >> --- >> arch/parisc/include/uapi/asm/unistd.h | 3 ++- >> arch/parisc/kernel/syscall_table.S | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/parisc/include/uapi/asm/unistd.h >> b/arch/parisc/include/uapi/asm/unistd.h >> index 2e639d7..dadcada 100644 >> --- a/arch/parisc/include/uapi/asm/unistd.h >> +++ b/arch/parisc/include/uapi/asm/unistd.h >> @@ -358,8 +358,9 @@ >> #define __NR_memfd_create (__NR_Linux + 340) >> #define __NR_bpf (__NR_Linux + 341) >> #define __NR_execveat (__NR_Linux + 342) >> +#define __NR_membarrier (__NR_Linux + 343) >> >> -#define __NR_Linux_syscalls (__NR_execveat + 1) >> +#define __NR_Linux_syscalls (__NR_membarrier + 1) >> >> >> #define __IGNORE_select /* newselect */ >> diff --git a/arch/parisc/kernel/syscall_table.S >> b/arch/parisc/kernel/syscall_table.S >> index 8eefb12..2faa43b 100644 >> --- a/arch/parisc/kernel/syscall_table.S >> +++ b/arch/parisc/kernel/syscall_table.S >> @@ -438,6 +438,7 @@ >> ENTRY_SAME(memfd_create) /* 340 */ >> ENTRY_SAME(bpf) >> ENTRY_COMP(execveat) >> + ENTRY_COMP(membarrier) > > This needs to be ENTRY_SAME(membarrier), since you don't have/need a > compat_membarrier() function. Allright, will fix. > > After changing to ENTRY_SAME() I did run the kselftest on parisc: > deller@ls3xx> ./membarrier_test > membarrier MEMBARRIER_CMD_QUERY syscall available. > membarrier: MEMBARRIER_CMD_SHARED success. > membarrier: tests done! And add your Tested-by tag, thanks! Mathieu > > Helge -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com