public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* BUG on booting 2.6.27-rc1
@ 2008-08-01 20:56 Steve Wise
  2008-08-01 21:15 ` Jeremy Fitzhardinge
  0 siblings, 1 reply; 3+ messages in thread
From: Steve Wise @ 2008-08-01 20:56 UTC (permalink / raw)
  To: linux-kernel

Anybody seen this?

Its on x86_64, FC7 distro quad core cpu.  I have 2 similar systems, and 
one boots up ok but the other hits this on -rc1 right off the bat.




Starting udev: ------------[ cut here ]------------
kernel BUG at kernel/stop_machine.c:151!
invalid opcode: 0000 [1] SMP
CPU 0
Modules linked in: dm_snapshot dm_zero dm_mirror dm_log dm_mod 
pata_jmicron ata_generic ata_piix libata sd_mod scsi_mod ext3 jbd 
mbcache [last unloaded: scsi_wait_scan]
Pid: 960, comm: modprobe Not tainted 2.6.27-rc1 #7
RIP: 0010:[<ffffffff8105be33>]  [<ffffffff8105be33>] 
__stop_machine+0x134/0x1ea
RSP: 0018:ffff88012e5dbd68  EFLAGS: 00010286
RAX: 00000000fffffff3 RBX: ffff88012b9b1d40 RCX: 0000000000000206
RDX: 000000000000100f RSI: 0000000000000246 RDI: ffffffff81380cb0
RBP: ffff88012dbd5e00 R08: 0000000000000000 R09: ffffffff813cfb28
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88012dbd5e00 R14: 0000000000000000 R15: 00007ff1dab40010
FS:  00007ff1daba26f0(0000) GS:ffffffff813d0b00(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00007ff1dab7b00f CR3: 000000012e4a8000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process modprobe (pid: 960, threadinfo ffff88012e5da000, task 
ffff88012d8c2490)
Stack:  ffffffff8105bcfc 0000000000000000 0000000000000000 0000000000000000
 ffffffff810517f7 ffffffffa00cc000 0000000000000000 ffffffff8101d469
 0000000000000063 ffffffff812501ce 0000000000000000 0000000000000000
Call Trace:
 [<ffffffff8105bcfc>] ? chill+0x0/0x3
 [<ffffffff810517f7>] ? __link_module+0x0/0x1f
 [<ffffffff8101d469>] ? module_finalize+0xa0/0x121
 [<ffffffff812501ce>] ? mutex_lock+0xd/0x1e
 [<ffffffff810517f7>] ? __link_module+0x0/0x1f
 [<ffffffff8105bf0a>] ? stop_machine+0x21/0x30
 [<ffffffff81052dd2>] ? load_module+0x11a0/0x1624
 [<ffffffff81196f5c>] ? bus_register+0x0/0x224
 [<ffffffff810f670f>] ? selinux_capable+0x87/0x90
 [<ffffffff810532a3>] ? sys_init_module+0x4d/0x1a7
 [<ffffffff8100bdbb>] ? system_call_fastpath+0x16/0x1b


Code: 00 83 cd ff e9 a0 00 00 00 48 89 c7 44 89 e6 e8 d8 95 fe ff 48 8b 
7d 00 48 8d 54 24 40 be 01 00 00 00 e8 c7 39 fd ff 85 c0 74 04 <0f> 0b 
eb fe 44 89 e7 48 c7 c6 98 0d 3d 81 e8 3a ea 0b 00 83 f8
RIP  [<ffffffff8105be33>] __stop_machine+0x134/0x1ea
 RSP <ffff88012e5dbd68>
---[ end trace 47a6f3d3cb718199 ]---


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BUG on booting 2.6.27-rc1
  2008-08-01 20:56 BUG on booting 2.6.27-rc1 Steve Wise
@ 2008-08-01 21:15 ` Jeremy Fitzhardinge
  2008-08-01 21:47   ` Steve Wise
  0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2008-08-01 21:15 UTC (permalink / raw)
  To: Steve Wise; +Cc: linux-kernel, Rusty Russell

Steve Wise wrote:
> Anybody seen this?
>
> Its on x86_64, FC7 distro quad core cpu.  I have 2 similar systems, 
> and one boots up ok but the other hits this on -rc1 right off the bat.
>
>
>
>
> Starting udev: ------------[ cut here ]------------
> kernel BUG at kernel/stop_machine.c:151!
> invalid opcode: 0000 [1] SMP
> CPU 0
> Modules linked in: dm_snapshot dm_zero dm_mirror dm_log dm_mod 
> pata_jmicron ata_generic ata_piix libata sd_mod scsi_mod ext3 jbd 
> mbcache [last unloaded: scsi_wait_scan]
> Pid: 960, comm: modprobe Not tainted 2.6.27-rc1 #7
> RIP: 0010:[<ffffffff8105be33>]  [<ffffffff8105be33>] 
> __stop_machine+0x134/0x1ea
> RSP: 0018:ffff88012e5dbd68  EFLAGS: 00010286
> RAX: 00000000fffffff3 RBX: ffff88012b9b1d40 RCX: 0000000000000206

RAX = -EACCES

Presumably that's being returned from security_task_setscheduler(), 
since it doesn't otherwise appear in __sched_setscheduler().  We 
probably shouldn't call that if !user.

diff -r 4f507097262d kernel/sched.c
--- a/kernel/sched.c	Fri Aug 01 13:14:44 2008 -0700
+++ b/kernel/sched.c	Fri Aug 01 14:13:59 2008 -0700
@@ -4998,19 +4998,21 @@
 			return -EPERM;
 	}
 
-#ifdef CONFIG_RT_GROUP_SCHED
-	/*
-	 * Do not allow realtime tasks into groups that have no runtime
-	 * assigned.
-	 */
-	if (user
-	    && rt_policy(policy) && task_group(p)->rt_bandwidth.rt_runtime == 0)
-		return -EPERM;
-#endif
-
-	retval = security_task_setscheduler(p, policy, param);
-	if (retval)
-		return retval;
+	if (user) {
+#ifdef CONFIG_RT_GROUP_SCHED
+		/*
+		 * Do not allow realtime tasks into groups that have no runtime
+		 * assigned.
+		 */
+		if (rt_policy(policy) && task_group(p)->rt_bandwidth.rt_runtime == 0)
+			return -EPERM;
+#endif
+
+		retval = security_task_setscheduler(p, policy, param);
+		if (retval)
+			return retval;
+	}
+
 	/*
 	 * make sure no PI-waiters arrive (or leave) while we are
 	 * changing the priority of the task:



    J

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BUG on booting 2.6.27-rc1
  2008-08-01 21:15 ` Jeremy Fitzhardinge
@ 2008-08-01 21:47   ` Steve Wise
  0 siblings, 0 replies; 3+ messages in thread
From: Steve Wise @ 2008-08-01 21:47 UTC (permalink / raw)
  To: Jeremy Fitzhardinge; +Cc: linux-kernel, Rusty Russell

That patch did it!

Thanks,

Steve.


Jeremy Fitzhardinge wrote:
> Steve Wise wrote:
>> Anybody seen this?
>>
>> Its on x86_64, FC7 distro quad core cpu.  I have 2 similar systems, 
>> and one boots up ok but the other hits this on -rc1 right off the bat.
>>
>>
>>
>>
>> Starting udev: ------------[ cut here ]------------
>> kernel BUG at kernel/stop_machine.c:151!
>> invalid opcode: 0000 [1] SMP
>> CPU 0
>> Modules linked in: dm_snapshot dm_zero dm_mirror dm_log dm_mod 
>> pata_jmicron ata_generic ata_piix libata sd_mod scsi_mod ext3 jbd 
>> mbcache [last unloaded: scsi_wait_scan]
>> Pid: 960, comm: modprobe Not tainted 2.6.27-rc1 #7
>> RIP: 0010:[<ffffffff8105be33>]  [<ffffffff8105be33>] 
>> __stop_machine+0x134/0x1ea
>> RSP: 0018:ffff88012e5dbd68  EFLAGS: 00010286
>> RAX: 00000000fffffff3 RBX: ffff88012b9b1d40 RCX: 0000000000000206
>
> RAX = -EACCES
>
> Presumably that's being returned from security_task_setscheduler(), 
> since it doesn't otherwise appear in __sched_setscheduler().  We 
> probably shouldn't call that if !user.
>
> diff -r 4f507097262d kernel/sched.c
> --- a/kernel/sched.c    Fri Aug 01 13:14:44 2008 -0700
> +++ b/kernel/sched.c    Fri Aug 01 14:13:59 2008 -0700
> @@ -4998,19 +4998,21 @@
>             return -EPERM;
>     }
>
> -#ifdef CONFIG_RT_GROUP_SCHED
> -    /*
> -     * Do not allow realtime tasks into groups that have no runtime
> -     * assigned.
> -     */
> -    if (user
> -        && rt_policy(policy) && 
> task_group(p)->rt_bandwidth.rt_runtime == 0)
> -        return -EPERM;
> -#endif
> -
> -    retval = security_task_setscheduler(p, policy, param);
> -    if (retval)
> -        return retval;
> +    if (user) {
> +#ifdef CONFIG_RT_GROUP_SCHED
> +        /*
> +         * Do not allow realtime tasks into groups that have no runtime
> +         * assigned.
> +         */
> +        if (rt_policy(policy) && 
> task_group(p)->rt_bandwidth.rt_runtime == 0)
> +            return -EPERM;
> +#endif
> +
> +        retval = security_task_setscheduler(p, policy, param);
> +        if (retval)
> +            return retval;
> +    }
> +
>     /*
>      * make sure no PI-waiters arrive (or leave) while we are
>      * changing the priority of the task:
>
>
>
>    J
> -- 
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-08-01 21:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-01 20:56 BUG on booting 2.6.27-rc1 Steve Wise
2008-08-01 21:15 ` Jeremy Fitzhardinge
2008-08-01 21:47   ` Steve Wise

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox