public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhiguo <yuzg@cn.fujitsu.com>
To: zhangxiliang <zhangxiliang@cn.fujitsu.com>
Cc: Eric Paris <eparis@redhat.com>, Steve Grubb <sgrubb@redhat.com>,
	viro@zeniv.linux.org.uk, Linux Audit <linux-audit@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix the kernel panic of audit_filter_task when key field is set
Date: Sat, 02 Aug 2008 10:51:21 +0800	[thread overview]
Message-ID: <4893CBA9.9020008@cn.fujitsu.com> (raw)
In-Reply-To: <4893C42A.60803@cn.fujitsu.com>


zhangxiliang wrote:

>  static int audit_match_perm(struct audit_context *ctx, int mask)
>  {
> +	if(!ctx)
> +		return 0;
>  	unsigned n = ctx->major;

Please check this patch with scripts/checkpatch.pl and then resend it.


>  	switch (audit_classify_syscall(ctx->arch, n)) {
>  	case 0:	/* native */
> @@ -284,6 +286,8 @@ static int audit_match_filetype(struct audit_context *ctx, int which)
>  {
>  	unsigned index = which & ~S_IFMT;
>  	mode_t mode = which & S_IFMT;
> +	if(!ctx)
> +		return 0;
>  	if (index >= ctx->name_count)
>  		return 0;
>  	if (ctx->names[index].ino == -1)
> 
> 


  reply	other threads:[~2008-08-02  2:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 11:15 [PATCH] Fix the kernel panic of audit_filter_task when key field is set zhangxiliang
2008-08-02  2:19 ` zhangxiliang
2008-08-02  2:51   ` Yu Zhiguo [this message]
2008-08-02  2:56     ` zhangxiliang
2008-08-04 10:20       ` Al Viro
2008-08-20 11:18       ` [PATCH] fix warning in audit_match_perm Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4893CBA9.9020008@cn.fujitsu.com \
    --to=yuzg@cn.fujitsu.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgrubb@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zhangxiliang@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox