From: "H. Peter Anvin" <hpa@zytor.com>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
tglx <tglx@linutronix.de>
Subject: Re: [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c
Date: Sat, 02 Aug 2008 21:01:55 -0700 [thread overview]
Message-ID: <48952DB3.20101@zytor.com> (raw)
In-Reply-To: <20080802212406.047e8ae6@paolo-desktop>
Paolo Ciarrocchi wrote:
>
> diff --git a/arch/x86/kernel/bios_uv.c b/arch/x86/kernel/bios_uv.c
> index c639bd5..100e759 100644
> --- a/arch/x86/kernel/bios_uv.c
> +++ b/arch/x86/kernel/bios_uv.c
> @@ -25,11 +25,21 @@ x86_bios_strerror(long status)
> {
> const char *str;
> switch (status) {
> - case 0: str = "Call completed without error"; break;
> - case -1: str = "Not implemented"; break;
> - case -2: str = "Invalid argument"; break;
> - case -3: str = "Call completed with error"; break;
> - default: str = "Unknown BIOS status code"; break;
> + case 0:
> + str = "Call completed without error";
> + break;
> + case -1:
> + str = "Not implemented";
> + break;
> + case -2:
> + str = "Invalid argument";
> + break;
> + case -3:
> + str = "Call completed with error";
> + break;
> + default:
> + str = "Unknown BIOS status code";
> + break;
> }
> return str;
> }
This should be an array in the first place...
-hpa
next prev parent reply other threads:[~2008-08-03 4:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 19:24 [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c Paolo Ciarrocchi
2008-08-03 4:01 ` H. Peter Anvin [this message]
2008-08-03 10:51 ` Stefan Richter
2008-08-03 11:54 ` Krzysztof Halasa
2008-08-03 12:21 ` Paolo Ciarrocchi
2008-08-05 2:15 ` H. Peter Anvin
2008-08-15 14:52 ` Ingo Molnar
2008-08-16 10:30 ` Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48952DB3.20101@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox