From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbcFTXkG (ORCPT ); Mon, 20 Jun 2016 19:40:06 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:59303 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbcFTXjr (ORCPT ); Mon, 20 Jun 2016 19:39:47 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Andrey Smirnov , Sascha Hauer , Russell King , linux-kernel@vger.kernel.org, Sascha Hauer , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Shawn Guo Subject: Re: [PATCH v3 0/5] i.MX L2-cache code cleanups and performance tweaks Date: Tue, 21 Jun 2016 01:07:55 +0200 Message-ID: <4896650.lS63LY4PpR@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1466296268-27099-1-git-send-email-andrew.smirnov@gmail.com> <114981982.VXDIiN0rdz@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Xr1/1IOnJDmi/dgfIT5KW1u7m2ojzMJeRhWItQZiQEc/DNjEoTN bN6ua3XOjKws7ar1PT7xfCbR6KR6Pl0Xykt6dfAEyIMR9Pgej/P4RY4qcTMnuvJrEcjuE0x HW9K6AepwX87dL0pQT94ZLcCiB6q8tHgXUnn5JjXhZC3O13Aj3HgO9+A2PpFIhYsEoyuoob pMyxYLkU6fZYgTxb56haA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/nQeFsZ0EKU=:UGaPBZkzPbjoVGO1J+er4I pGnfpaso6YU4kugBmP2NFieQXuwl8n0Nr3d+44LcFN182ZjyKI5YjplXE8hap0oPxk0zGINjz 8F5EdG8V42lQV7cOm8FudtKhY6177Vq3ZDNmDxCXeUIzcBiBhLPNUs3n/PhLb2/muITFr10ct QQk4B28fPutsu/U2MycLv+n134KtJM1aFyLg11VEO1jaJPHIuzNTfBNp0AbI7D0JIjsZwh7hc uE8DPzP3MoszO3Py1RkPjUG7JKCsDm5ilPKxv7PhwhyYvwUseactFNShCSu99LzJyPW9AWJhm 6fnx1Z0uCfywV3QJHchSxsCBXeY3GVizGOW2M8WZuf5YwHWeIXY3P6rpwws90tcncJZF3Mnol YE72ko4BTOI6lqvRtP8TmU06cc2qjn9HuptRiZ76d1jqQ8rCaZaqsWEbIuXKQCfgU6APWEHXO eP11zjtYhM2exkuwdJGjmEZMO+VRFPe5kgR5A8629LG258Wd9qa5BK3LYRHxuSTCvOVFJumIR 5jvhhY0fuosv0wn15YR7y5ytr7BPZx8MiEffQVCXsgCWO2QinKPi179atM+Gp+3qG9FdbUemJ aQIyb42sZZ4IXU28jCrTM7tjdEgoFbcz0/lMbyclAuI9cGxdrh022xqblgbYfIT7wWWaJN87w tnCINs7i5xN7nlGXZhv154hEH+prn87FPld+krR5UibXmnRYnVM5qVMjs6ymQWB6LfMa/9pli s9ObV3S8M5aFy+oF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 19, 2016 10:53:13 AM CEST Andrey Smirnov wrote: > One more question, less about your patches than the existing code: > > > > After going through the current users of l2x0_init for board files, > > I noticed that imx35 enables l2x0 for both dts and all the board files > > and has an arm,l210-cache node in its dts, but imx31 only enables > > it for the board file and in the dt case doesn't init the cache nor > > does it have the dts node. > > > > I'm guessing this is a bug on i.mx31 dt support, right? > > I would agree that it is. OTOH, I can't find any i.MX31 boards that > use device tree. The only file that references imx31.dtsi is > imx31-bug.dts, but at the same time that board has a dedicated board > file (mach-bug.c) so I wonder if it was ever used. My understanding is that many of the i.mx dts files were introduced a few years ago as conversions of the board files, and we are now in the (slow) process of removing the board files, assuming that everyone has had time for migration if they still run that hardware on new kernels, or that it doesn't hurt if nobody uses it. This one was added with the comment arm/dts: Add support for i.MX31 bug 1.x board from buglabs. Only the main UART and the memory node information are added. and it's unclear if that has ever been tested. A few device nodes were added to the imx31.dtsi file later, indicating that it probably had /some/ testing, but no other board file was ever added as you say. The only difference I see between mach-bug.c and imx31-bug.dts is the configuration of the uart pins. I don't know if that is required in the dts, because I'd assume that the boot loader would leave the pinmux in a state in which the console uart works. > It looks like Sacha was the author of i.MX31, Sascha do you have any > comment on this? > > There's also another small cleanup opportunity in collapsing > imx31_dt_timer_init() and mx31_clocks_init_dt() into a single function > given how the latter always returns 0 and can be converted to void. Or we could go one step further and use CLK_OF_DECLARE() to remove that init function entirely. Same thing for mx31_init_irq and IRQCHIP_DECLARE(). > I am more than happy to make both changes and include them in the set, > but I only have i.MX6 HW, and would only be able to do a compile-test, > so I am not sure if I should. Let's wait for Sascha to reply. Arnd