From: Joe Peterson <joe@skyrush.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: tty: ctrl-c not always echoed, especially under load
Date: Mon, 04 Aug 2008 17:36:43 -0600 [thread overview]
Message-ID: <4897928B.4090603@skyrush.com> (raw)
In-Reply-To: <20080805001129.72d06e60@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> If the output buffer is full then echoed characters/^C etc will vanish the
> way n_tty implements its buffering internally. It's always worked that
> way.
But since the flush is done just prior, shouldn't the buffer be empty
just before the ^C is written? Or are you saying that the buffer could
refill in the meantime (between the flush and the ^C) if the chars are
comming in too fast?
What about the order of flush?... Currently, it is:
n_tty_flush_buffer(tty); (ldisc buf)
tty_driver_flush_buffer(tty); (driver buf)
Would it be better to reverse this order, flushing the driver buffer
first so characters do not then refill the ldisc buffer before the
driver buffer can be flushed?
-Thanks, Joe
next prev parent reply other threads:[~2008-08-04 23:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 22:03 tty: ctrl-c not always echoed, especially under load Joe Peterson
2008-08-04 23:11 ` Alan Cox
2008-08-04 23:36 ` Joe Peterson [this message]
2008-08-06 20:17 ` Joe Peterson
2008-08-07 19:37 ` Alan Cox
2008-08-07 20:31 ` Joe Peterson
2008-08-11 15:14 ` Joe Peterson
2008-08-11 16:39 ` Alan Cox
2008-08-11 17:41 ` Joe Peterson
2008-08-14 16:19 ` [PATCH] " Joe Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4897928B.4090603@skyrush.com \
--to=joe@skyrush.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox