From: "H. Peter Anvin" <hpa@zytor.com>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Krzysztof Halasa <khc@pm.waw.pl>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
tglx <tglx@linutronix.de>
Subject: Re: [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c
Date: Mon, 04 Aug 2008 19:15:55 -0700 [thread overview]
Message-ID: <4897B7DB.7040507@zytor.com> (raw)
In-Reply-To: <4d8e3fd30808030521t351a8564yfb93211f7239613c@mail.gmail.com>
Paolo Ciarrocchi wrote:
>
> _much worse_? Wow, I thought the opposite.
> Anyway, that's just a coding style patch, feel free to simply not apply it as
> it's really a matter of personal taste but be sure that I'm not
> blindly changing the code
> accordingly to checkpatch. That might be almost true when I started
> doing this kind of patches months
> ago but it's definitely not true anymore.
>
In this case, the real problem is that the original code used a switch
statement where it really should have used a table.
-hpa
next prev parent reply other threads:[~2008-08-05 2:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 19:24 [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c Paolo Ciarrocchi
2008-08-03 4:01 ` H. Peter Anvin
2008-08-03 10:51 ` Stefan Richter
2008-08-03 11:54 ` Krzysztof Halasa
2008-08-03 12:21 ` Paolo Ciarrocchi
2008-08-05 2:15 ` H. Peter Anvin [this message]
2008-08-15 14:52 ` Ingo Molnar
2008-08-16 10:30 ` Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4897B7DB.7040507@zytor.com \
--to=hpa@zytor.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox