public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SLUB: detach SLUB_DEBUG and SYSFS
Date: Tue, 05 Aug 2008 09:33:33 -0500	[thread overview]
Message-ID: <489864BD.1060005@linux-foundation.org> (raw)
In-Reply-To: <20080804220247.GA10159@martell.zuzino.mipt.ru>

Alexey Dobriyan wrote:
> On Mon, Aug 04, 2008 at 05:10:37PM +0300, Pekka Enberg wrote:
>> Christoph Lameter wrote:
>>> Pekka Enberg wrote:
>>>> Alexey Dobriyan wrote:
>>>>> Right now, SYSFS=n means no SLUB debugging, no even basic poisoning,
>>>>> to hell with tunables.
>>>> Applied, thanks!
>>> Do not apply. This partially reverts an earlier commit and would cause 
>>> build
>>> issues because the #ifdef parts in slub.c were not reverted.
>> Aww, crap. OK, taking it out.
> 
> OK, I'll test-compile it to death.

Not sure what the point would be. If you look at the commit you are reverting
then its clear what configurations will break,

> For now, do you agree that SYSFS=n users shouldn't be discriminated
> against poisoning?

If you want a minimal memory footprint then I thought that also implies that
the debug code would not be compiled in?

> As real world situation, NET_NS feature which is currently in
> active development doesn't work with SYSFS, so it was a bit of cold
> shower to realise that I did much testing of conntracking in netns
> without poisoning. :-(

Ohh.. There are kernel features that conflict with SYSFS?




  parent reply	other threads:[~2008-08-05 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01  0:04 [PATCH] SLUB: detach SLUB_DEBUG and SYSFS Alexey Dobriyan
2008-08-01 13:28 ` Christoph Lameter
2008-08-02  8:34 ` Pekka Enberg
2008-08-04 13:23   ` Christoph Lameter
2008-08-04 14:10     ` Pekka Enberg
2008-08-04 22:02       ` Alexey Dobriyan
2008-08-04 22:06         ` Pekka Enberg
2008-08-05 14:33         ` Christoph Lameter [this message]
2008-08-03 18:28 ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489864BD.1060005@linux-foundation.org \
    --to=cl@linux-foundation.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox