* Re: PCI: Limit VPD length for Broadcom 5708S [not found] ` <2d9716d7-99a4-4d17-9cae-83842e216c8c@y19g2000prn.googlegroups.com> @ 2008-08-05 18:49 ` Dean Hildebrand 2008-08-07 15:56 ` Jesse Barnes 0 siblings, 1 reply; 4+ messages in thread From: Dean Hildebrand @ 2008-08-05 18:49 UTC (permalink / raw) To: linux-kernel; +Cc: jbarnes, dada1 > I have no idea if 5706S and 5709S also needs this truncation ofVPDlength It seems that our IBM Blade servers using 5706S also require this fix. We have confirmed that the patch below works on 2.6.27-rc1. diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c linux-2.6.27-rc1-fix/drivers/pci/quirks.c --- linux-2.6.27-rc1/drivers/pci/quirks.c 2008-08-05 10:51:42.000000000 -0700 +++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c 2008-08-05 10:50:57.000000000 -0700 @@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI */ static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev) { - /* Only disable the VPD capability for 5706, 5708, and 5709 rev. A */ + /* Only disable the VPD capability for 5706, 5706S, 5708, and 5709 rev. A */ if ((dev->device == PCI_DEVICE_ID_NX2_5706) || (dev->device == PCI_DEVICE_ID_NX2_5708) || + (dev->device == PCI_DEVICE_ID_NX2_5706S) || ((dev->device == PCI_DEVICE_ID_NX2_5709) && (dev->revision & 0xf0) == 0x0)) { if (dev->vpd) Please cc me on the response. Thanks, Dean Hildebrand IBM Almaden dhildeb@us.ibm.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PCI: Limit VPD length for Broadcom 5708S 2008-08-05 18:49 ` PCI: Limit VPD length for Broadcom 5708S Dean Hildebrand @ 2008-08-07 15:56 ` Jesse Barnes 2008-08-08 0:31 ` Dean Hildebrand 0 siblings, 1 reply; 4+ messages in thread From: Jesse Barnes @ 2008-08-07 15:56 UTC (permalink / raw) To: Dean Hildebrand; +Cc: linux-kernel, dada1 On Tuesday, August 5, 2008 11:49 am Dean Hildebrand wrote: > > I have no idea if 5706S and 5709S also needs this truncation ofVPDlength > > It seems that our IBM Blade servers using 5706S also require this > fix. We have confirmed that the patch below works on 2.6.27-rc1. > > > diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c > linux-2.6.27-rc1-fix/drivers/pci/quirks.c > --- linux-2.6.27-rc1/drivers/pci/quirks.c 2008-08-05 > 10:51:42.000000000 -0700 > +++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c 2008-08-05 > 10:50:57.000000000 -0700 > @@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI > */ > static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev) > { > - /* Only disable the VPD capability for 5706, 5708, and 5709 > rev. A */ > + /* Only disable the VPD capability for 5706, 5706S, 5708, and > 5709 rev. A */ > if ((dev->device == PCI_DEVICE_ID_NX2_5706) || > (dev->device == PCI_DEVICE_ID_NX2_5708) || > + (dev->device == PCI_DEVICE_ID_NX2_5706S) || > ((dev->device == PCI_DEVICE_ID_NX2_5709) && > (dev->revision & 0xf0) == 0x0)) { > if (dev->vpd) Looks fine. Can you respin against my for-linus branch and resubmit with a signed-off-by and full changelog? Thanks, Jesse ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PCI: Limit VPD length for Broadcom 5708S 2008-08-07 15:56 ` Jesse Barnes @ 2008-08-08 0:31 ` Dean Hildebrand 2008-08-08 0:50 ` Jesse Barnes 0 siblings, 1 reply; 4+ messages in thread From: Dean Hildebrand @ 2008-08-08 0:31 UTC (permalink / raw) To: Jesse Barnes; +Cc: linux-kernel, dada1 Jesse Barnes wrote: > On Tuesday, August 5, 2008 11:49 am Dean Hildebrand wrote: >>> I have no idea if 5706S and 5709S also needs this truncation ofVPDlength >> It seems that our IBM Blade servers using 5706S also require this >> fix. We have confirmed that the patch below works on 2.6.27-rc1. >> >> diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c >> linux-2.6.27-rc1-fix/drivers/pci/quirks.c >> --- linux-2.6.27-rc1/drivers/pci/quirks.c 2008-08-05 >> 10:51:42.000000000 -0700 >> +++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c 2008-08-05 >> 10:50:57.000000000 -0700 >> @@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI >> */ >> static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev) >> { >> - /* Only disable the VPD capability for 5706, 5708, and 5709 >> rev. A */ >> + /* Only disable the VPD capability for 5706, 5706S, 5708, and >> 5709 rev. A */ >> if ((dev->device == PCI_DEVICE_ID_NX2_5706) || >> (dev->device == PCI_DEVICE_ID_NX2_5708) || >> + (dev->device == PCI_DEVICE_ID_NX2_5706S) || >> ((dev->device == PCI_DEVICE_ID_NX2_5709) && >> (dev->revision & 0xf0) == 0x0)) { >> if (dev->vpd) > Looks fine. Can you respin against my for-linus branch and resubmit with a > signed-off-by and full changelog <cid:part1.05050500.03020803@gmail.com>Ok, here it is. ---- BCM5706S wont work correctly unless VPD length truncated to 128 Signed-off-by: Dean Hildebrand <dhildeb@us.ibm.com> --- drivers/pci/quirks.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 59667e5..9236e7f 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1757,9 +1757,11 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VIA, 0x324e, quirk_via_cx700_pci_parking_c static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev) { /* - * Only disable the VPD capability for 5706, 5708, 5708S and 5709 rev. A + * Only disable the VPD capability for 5706, 5706S, 5708, + * 5708S and 5709 rev. A */ if ((dev->device == PCI_DEVICE_ID_NX2_5706) || + (dev->device == PCI_DEVICE_ID_NX2_5706S) || (dev->device == PCI_DEVICE_ID_NX2_5708) || (dev->device == PCI_DEVICE_ID_NX2_5708S) || ((dev->device == PCI_DEVICE_ID_NX2_5709) && -- 1.5.2.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: PCI: Limit VPD length for Broadcom 5708S 2008-08-08 0:31 ` Dean Hildebrand @ 2008-08-08 0:50 ` Jesse Barnes 0 siblings, 0 replies; 4+ messages in thread From: Jesse Barnes @ 2008-08-08 0:50 UTC (permalink / raw) To: Dean Hildebrand; +Cc: linux-kernel, dada1 On Thursday, August 7, 2008 5:31 pm Dean Hildebrand wrote: > BCM5706S wont work correctly unless VPD length truncated to 128 > > Signed-off-by: Dean Hildebrand <dhildeb@us.ibm.com> Looks like it got wrapped, but I fixed it up by hand, thanks. Jesse ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-08 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <aVL4E-5C9-7@gated-at.bofh.it>
[not found] ` <2d9716d7-99a4-4d17-9cae-83842e216c8c@y19g2000prn.googlegroups.com>
2008-08-05 18:49 ` PCI: Limit VPD length for Broadcom 5708S Dean Hildebrand
2008-08-07 15:56 ` Jesse Barnes
2008-08-08 0:31 ` Dean Hildebrand
2008-08-08 0:50 ` Jesse Barnes
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox