From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
krzysztof.h1@poczta.fm, adaplas@pol.net,
akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: 2.6.27-rc1: softcursor behaviour changed
Date: Thu, 07 Aug 2008 12:17:21 +0100 [thread overview]
Message-ID: <489AD9C1.8020405@eu.citrix.com> (raw)
In-Reply-To: <20080807085733.GA1560@elf.ucw.cz>
Pavel Machek wrote:
> Hi!
>
>> In 2.6.26, this
>>
>> echo -e "\33[10;5000]\33[11;50]\33[?18;0;136c\33[?102m"
>>
>> produces some variation on cursor. on 2.6.27-rc1, I have no cursor at
>> all :-(.
>
> The patch that changed it is below... and I must say I liked the old
> behaviour better. Unlike blinking, high-brightness background is
> actually useful. Can we get that one reverted?
The problem is not a matter of taste but a matter of correctness: the
build_attr function in drivers/char/vt.c stores the blink attribute as
the forth bit of the background color.
Then in fbcon we are interpreting the same forth bit of the background
color as intensity bit.
My patch fixes that.
next prev parent reply other threads:[~2008-08-07 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 21:20 2.6.27-rc1: softcursor behaviour changed Pavel Machek
2008-08-07 8:57 ` Pavel Machek
2008-08-07 11:17 ` Stefano Stabellini [this message]
2008-08-07 22:07 ` Pavel Machek
2008-08-08 9:49 ` Stefano Stabellini
2008-08-08 18:17 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489AD9C1.8020405@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=adaplas@pol.net \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox