RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?

Jie Yang
2008-08-08T03:12:36Z

On Friday, August 08, 2008 12:25 AM
roel kluin <roel.kluin@gmail.com> wrote

>
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> diff --git
> a/drivers/net/atl1e/atl1e_ethtool.c
> b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct
> net_device *netdev, struct ethtool_wolinfo *wol)
> struct atl1e_adapter *adapter = netdev_priv(netdev);
>
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
> return -EOPNOTSUPP;
> /* these settings will always override what we
> currently have */
> adapter->wol = 0;
>

Yes, it should be this, thanks!

Acked-by: Jie Yang <jie.yang@atheros.com>

BTW: resend on the comments from Jay Cliburn <jacliburn@bellsouth.net>

Thanks Jay