From: "H. Peter Anvin" <hpa@kernel.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Zachary Amsden <zach@vmware.com>,
Alok Kataria <akataria@vmware.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]Fix broken VMI in 2.6.27-rc..
Date: Thu, 07 Aug 2008 16:51:04 -0700 [thread overview]
Message-ID: <489B8A68.10900@kernel.org> (raw)
In-Reply-To: <489B8948.6060003@goop.org>
Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> The fixmap area should never have been made movable. It's utter
>> braindamage.
>
> Shrug. It's been like that for a couple of years now. It was one of
> the very first paravirt-ops patches. It wasn't controversial then, and
> nobody seems to have noticed since.
The Linux kernel was never a paragon of perfection - it was never meant
to be. Just because a bit of cruft went unnoticed into the kernel
doesn't mean we shouldn't fix it.
>> Given the x86 architecture, it's inevitable that PV will want to
>> reserve address space at the top of memory, and therefore the fixmap
>> area needs to be moved out of that space.
>
> OK. But there's a few places where the code uses FIXADDR_TOP to mean
> "top of kernel address space", so we'd need to come up with a proper
> symbol for that.
I suggest KERNEL_TOP.
-hpa
next prev parent reply other threads:[~2008-08-07 23:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 19:12 [PATCH]Fix broken VMI in 2.6.27-rc Alok Kataria
2008-08-07 21:20 ` H. Peter Anvin
2008-08-07 21:27 ` Zachary Amsden
2008-08-07 21:34 ` H. Peter Anvin
2008-08-07 21:42 ` Zachary Amsden
2008-08-07 21:52 ` H. Peter Anvin
2008-08-07 21:55 ` Zachary Amsden
2008-08-07 22:17 ` H. Peter Anvin
2008-08-07 22:38 ` Linus Torvalds
2008-08-07 22:58 ` H. Peter Anvin
2008-08-07 23:08 ` Linus Torvalds
2008-08-07 23:12 ` H. Peter Anvin
2008-08-07 23:26 ` Zachary Amsden
2008-08-07 23:49 ` Jeremy Fitzhardinge
2008-08-07 23:23 ` Jeremy Fitzhardinge
2008-08-08 19:15 ` Alok Kataria
2008-08-08 22:23 ` H. Peter Anvin
2008-08-07 23:21 ` Jeremy Fitzhardinge
2008-08-07 23:27 ` H. Peter Anvin
2008-08-07 23:46 ` Jeremy Fitzhardinge
2008-08-07 23:51 ` H. Peter Anvin [this message]
2008-08-08 0:01 ` Yinghai Lu
2008-08-08 0:11 ` H. Peter Anvin
2008-08-08 0:10 ` Jeremy Fitzhardinge
2008-08-08 0:13 ` H. Peter Anvin
2008-08-08 0:23 ` Jeremy Fitzhardinge
2008-08-08 0:29 ` H. Peter Anvin
2008-08-08 6:10 ` Jeremy Fitzhardinge
2008-08-08 16:13 ` H. Peter Anvin
2008-08-08 1:14 ` Zachary Amsden
2008-08-08 1:19 ` H. Peter Anvin
2008-08-08 1:28 ` Zachary Amsden
2008-08-07 21:41 ` Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489B8A68.10900@kernel.org \
--to=hpa@kernel.org \
--cc=akataria@vmware.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox