From: "H. Peter Anvin" <hpa@kernel.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Zachary Amsden <zach@vmware.com>,
Alok Kataria <akataria@vmware.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]Fix broken VMI in 2.6.27-rc..
Date: Fri, 08 Aug 2008 09:13:54 -0700 [thread overview]
Message-ID: <489C70C2.1070708@kernel.org> (raw)
In-Reply-To: <489BE351.5030206@goop.org>
Jeremy Fitzhardinge wrote:
>>
>> No, but it's hardly vast effort, either.
>
> Thinking about it, the fixmap really has to be as high as possible. If
> it were any lower, then it would either truncate the 1:1 mapping, or
> shadow some physical memory.
>
The proposal was to put it *before* the 1:1 mapping:
FIX_HOLE would start at TASK_SIZE
PAGE_OFFSET would shift to TASK_SIZE + PMD_PAGE_SIZE
All the remaining offsets remain as-is.
It's slightly less efficient than the current version, since we can't
share the PDE page for the fixmap with the final vmalloc map, but not
terribly so.
-hpa
next prev parent reply other threads:[~2008-08-08 16:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 19:12 [PATCH]Fix broken VMI in 2.6.27-rc Alok Kataria
2008-08-07 21:20 ` H. Peter Anvin
2008-08-07 21:27 ` Zachary Amsden
2008-08-07 21:34 ` H. Peter Anvin
2008-08-07 21:42 ` Zachary Amsden
2008-08-07 21:52 ` H. Peter Anvin
2008-08-07 21:55 ` Zachary Amsden
2008-08-07 22:17 ` H. Peter Anvin
2008-08-07 22:38 ` Linus Torvalds
2008-08-07 22:58 ` H. Peter Anvin
2008-08-07 23:08 ` Linus Torvalds
2008-08-07 23:12 ` H. Peter Anvin
2008-08-07 23:26 ` Zachary Amsden
2008-08-07 23:49 ` Jeremy Fitzhardinge
2008-08-07 23:23 ` Jeremy Fitzhardinge
2008-08-08 19:15 ` Alok Kataria
2008-08-08 22:23 ` H. Peter Anvin
2008-08-07 23:21 ` Jeremy Fitzhardinge
2008-08-07 23:27 ` H. Peter Anvin
2008-08-07 23:46 ` Jeremy Fitzhardinge
2008-08-07 23:51 ` H. Peter Anvin
2008-08-08 0:01 ` Yinghai Lu
2008-08-08 0:11 ` H. Peter Anvin
2008-08-08 0:10 ` Jeremy Fitzhardinge
2008-08-08 0:13 ` H. Peter Anvin
2008-08-08 0:23 ` Jeremy Fitzhardinge
2008-08-08 0:29 ` H. Peter Anvin
2008-08-08 6:10 ` Jeremy Fitzhardinge
2008-08-08 16:13 ` H. Peter Anvin [this message]
2008-08-08 1:14 ` Zachary Amsden
2008-08-08 1:19 ` H. Peter Anvin
2008-08-08 1:28 ` Zachary Amsden
2008-08-07 21:41 ` Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489C70C2.1070708@kernel.org \
--to=hpa@kernel.org \
--cc=akataria@vmware.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox